Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cucumber):[#226] Fix umbrella e2e test scenarios #856

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Jul 26, 2024

Description

Fixed umbrella cucumber tests.
All tests are green now https://reports.cucumber.io/reports/f6196d3c-c1be-4753-a391-f8dde430ffe4

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ds-jhartmann ds-jhartmann reopened this Jul 26, 2024
@ds-jhartmann ds-jhartmann force-pushed the chore/fix-umbrella-e2e-tests branch from 0eb660f to d25049c Compare July 26, 2024 14:28
@eclipse-tractusx eclipse-tractusx deleted a comment from github-actions bot Jul 26, 2024
@eclipse-tractusx eclipse-tractusx deleted a comment from github-actions bot Jul 26, 2024
@eclipse-tractusx eclipse-tractusx deleted a comment from github-actions bot Jul 26, 2024
Copy link

github-actions bot commented Jul 29, 2024

Test Results

16 tests   - 20    1 ✅  - 26   0s ⏱️ - 16m 57s
 1 suites ± 0    0 💤 ± 0 
 1 files   ± 0   15 ❌ + 6 

For more details on these failures, see this check.

Results for commit 943f7ea. ± Comparison against base commit f0098f4.

This pull request removes 36 and adds 16 tests. Note that renamed tests count towards both.
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model A for BMW [BPNL00000003AYRE]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model B for MercedesBenz [BPNL00000003AYRE]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model C for SAP [BPNL00000003AYRE]
IRS Batch Processing ‑ Check correct job executions of batch processing (SingleLevelBomAsBuilt/SerialPart 3.0.0)
IRS Policy Store ‑ Policy Store API:  Update a policy validUntil date for a policy that is associated to multiple BPNs
IRS Policy Store ‑ Policy Store API: Add BPN to policy
IRS Policy Store ‑ Policy Store API: Add policyId to given BPNs
IRS Policy Store ‑ Policy Store API: Delete policy for BPN
IRS Policy Store ‑ Policy Store API: Delete some policies
IRS Policy Store ‑ Policy Store API: Fetching policies by BPNLs should fail for invalid BPNLs (bad case)
…
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier BPNL in investigation job with four level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier BPNL in investigation job with several impacted nodes has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier bpnl in investigation job with one level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier bpnl in investigation job with three level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job for globalAssetId with missing BPNS in PartSiteInformationAsPlanned is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job for globalAssetId with missing PartSiteInformationAsPlanned is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with invalid request is handled correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with several relationships for valid globalAssetId and BPN is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with unknown globalAssetId and valid BPN is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with valid globalAssetId and BPN is processed correctly
…

♻️ This comment has been updated with latest results.

Copy link

CHANGELOG file was not updated! Make sure to include important changes.

Copy link
Contributor

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -35 to -36
schedule:
- cron: '0 2 * * 1-5' # At 02:00 on every day-of-week from Monday through Friday.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no scheduled run anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Workflow is triggered on every push to main, I don't think it is necessary to run the Umbrella Cucumber Tests scheduled.
The Umbrella Environment is created from scratch every time, so nothing will change between the latest push to main and the scheduled execution

Copy link

Copy link
Contributor

@ds-lcapellino ds-lcapellino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-lcapellino ds-lcapellino merged commit daf495c into main Jul 29, 2024
17 of 19 checks passed
@ds-lcapellino ds-lcapellino deleted the chore/fix-umbrella-e2e-tests branch July 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants