538 propagate exceptions via either and add suppressed #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using Either and addSuppressed
test
…uppressed # Conflicts: # irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/central/CentralDigitalTwinRegistryServiceTest.java
dsmf
commented
Jun 28, 2024
irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java
Outdated
Show resolved
Hide resolved
…concurrent/ResultFinder.java
dsmf
commented
Jun 28, 2024
irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcSubmodelClientImpl.java
Outdated
Show resolved
Hide resolved
…nt/EdcSubmodelClientImpl.java
ds-jhartmann
changed the base branch from
main
to
fix/538-propagate-exceptions-via-Either-and-addSuppressed
ds-jhartmann
approved these changes
Jul 8, 2024
| @@ -39,7 +40,7 @@ public interface DigitalTwinRegistryService { | |||
| * @param bpn the BPN to retrieve the shells for | |||
| * @return the collection of asset administration shells | |||
| */ | |||
| default Collection<Shell> lookupShellsByBPN(final String bpn) throws RegistryServiceException { | |||
| default Collection<Either<Exception, Shell>> lookupShellsByBPN(final String bpn) throws RegistryServiceException { | |||
There was a problem hiding this comment.
When changing this interface, we need to make sure to document how to use this.
This interface is used by trace-x
ds-jhartmann
merged commit 26eab7a
into
eclipse-tractusx:fix/538-propagate-exceptions-via-Either-and-addSuppressed
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: