Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EDC to 0.7.0 #586

Merged
merged 30 commits into from
May 6, 2024
Merged

Update EDC to 0.7.0 #586

merged 30 commits into from
May 6, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented May 6, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

ds-jhartmann and others added 30 commits April 19, 2024 16:15
# Conflicts:
#	irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcSubmodelClientTest.java
#	local/testing/testdata/transform-and-upload.py
Copy link

gitguardian bot commented May 6, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9383100 Ignored Generic High Entropy Secret cd45727 irs-api/src/test/java/org/eclipse/tractusx/irs/WiremockSupport.java View secret
9383100 Ignored Generic High Entropy Secret 36a46a8 irs-api/src/test/java/org/eclipse/tractusx/irs/WiremockSupport.java View secret
10616813 Triggered Generic High Entropy Secret cd45727 irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
10616813 Triggered Generic High Entropy Secret 2e4245b irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
10616814 Triggered Generic High Entropy Secret cd45727 irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
10616814 Triggered Generic High Entropy Secret cd45727 irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
10616814 Triggered Generic High Entropy Secret b9d6827 irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
10616814 Triggered Generic High Entropy Secret b9d6827 irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackControllerTest.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-mwesener ds-mwesener merged commit f52716a into eclipse-tractusx:main May 6, 2024
15 of 18 checks passed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants