Feat/518 policy store API integration tests #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for usage of request / response classes in policy store tests
need to be reworked though, see TODOs in feature file
…dd precondition check
by copying the few small records that we use in the tests
- use ObjectMapper instead of JsonReader - use JsonNode instead of JsonObject
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @NoArgsConstructor | ||
| public static final class PolicyAttributes { | ||
| private String policyId; | ||
| private List<String> bpnls; |
Check notice
Code scanning / CodeQL
Exposing internal representation Note test
There was a problem hiding this comment.
this is ok for test IMHO
dsmf
changed the title
10 tasks
temporarily set IRS DEV Cucumber Integration test filter to tests from branch
back to original exportFilter
|
|
||
| - name: Create pull request | ||
| id: cpr | ||
| uses: peter-evans/create-pull-request@v5 |
Check notice
Code scanning / KICS
Unpinned Actions Full Length Commit SHA Note
it is sufficient to hold AuthenticationProperties.AuthenticationPropertiesBuilder as attribute
…-tests--reworked # Conflicts: # CHANGELOG.md
|
|
||
| - name: Create pull request | ||
| id: cpr | ||
| uses: peter-evans/create-pull-request@v5 |
Check notice
Code scanning / KICS
Unpinned Actions Full Length Commit SHA
reason: test only Policy Store API releated scenarios in the branch
feat(impl):[#585] newest dataset reduced
sync with upstream
|
something is wrong with the merge here |
ds-jhartmann
added a commit
to ds-jhartmann/item-relationship-service
that referenced
this pull request
Jun 13, 2024
…-helm-release-6.8.0 Prepare Helm release for next version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: