-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes and caching discovery finder requests #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m DigitalTwinRegistryClientLocalStub in registry-client and moved bean creation to irs-api
…rofile from irs-registry-client
…thod for test without aspects
feat(impl):[#253] publish batch finish event only when its completed/…
…lient in order to be able to apply caching annotations later
…DiscoveryEndpoints calls
…findDiscoveryEndpoints calls - harden asserts - prefer constants over duplicated literals - improve structure and naming - remove superfluous assertion descriptions
…for-Discovery-Finder-requests
…of calling method directly in the test
Merge remote-tracking branch 'origin/feat(impl)/225-Use-caching-for-Discovery-Finder-requests' into feat(impl)/225-Use-caching-for-Discovery-Finder-requests # Conflicts: # CHANGELOG.md
TESTING/Updated tavern tests and expected files for cucumber tests
Co-authored-by: Jaro Hartmann <[email protected]>
Co-authored-by: Jaro Hartmann <[email protected]>
…criptors-not-filtered feat(impl):[#325] - fix submodel descriptors not filtered
Feat/#325 Fixed tavern check method for submodelDescriptors
…tion-of-clients-independent-of-local-environment feat(irs-registry-client-irs-api):[#202] removed auto-detect bean from DigitalTwinRegistryClientLocalStub in registry-client and moved bean creation to irs-api
Co-authored-by: Jaro Hartmann <[email protected]>
Co-authored-by: Jaro Hartmann <[email protected]>
Co-authored-by: Jaro Hartmann <[email protected]>
…r-Discovery-Finder-requests Feat(impl)/225 use caching for discovery finder requests
dsmf
requested review from
ds-alexander-bulgakov,
ds-psosnowski,
ds-jhartmann and
ds-ext-kmassalski
December 13, 2023 13:31
ds-jhartmann
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ds-jhartmann
added a commit
that referenced
this pull request
Feb 22, 2024
chore(charts): Update IRS chart version to 5.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed:
Updated:
Added:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: