Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞[R24.8] BusinessPartnerNumber and EndpointURL are not filled in tombstone #841

Closed
mkanal opened this issue Jul 22, 2024 · 2 comments
Closed

🐞[R24.8] BusinessPartnerNumber and EndpointURL are not filled in tombstone #841

mkanal opened this issue Jul 22, 2024 · 2 comments
Assignees
@dsmf
Labels
bug Something isn't working R24.8

Comments

@mkanal
Copy link
Contributor

mkanal commented Jul 22, 2024

Description

Current behavior

  • Tombstone attribute BusinessPartnerNumber in null (BusinessPartnerNumber exisits for Tombstone )
  • Tombstone attribute EndpointURL is null (EndpointURL exisits for Tombstone)

Expected behavior

  • BPN and EndpointURL attributes are filled when present

Steps to reproduce the Bug

  • Execute scenario

Image
@mkanal mkanal added this to IRS Jul 22, 2024
@mkanal mkanal moved this to next in IRS Jul 22, 2024
@mkanal mkanal added bug Something isn't working R24.8 labels Jul 22, 2024
@mkanal mkanal moved this from next to backlog in IRS Jul 22, 2024
@mkanal mkanal modified the milestone: 24.03 Feature Freeze Jul 22, 2024
@dsmf dsmf moved this from backlog to wip in IRS Jul 26, 2024
@dsmf dsmf self-assigned this Jul 26, 2024
@dsmf dsmf mentioned this issue Jul 29, 2024
Merged
2 tasks
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(impl): [eclipse-tractusx#841] add helper methods to ProcessingE…
8a17e05 
…rrorBuilder
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(impl): [eclipse-tractusx#841] allow to continue builder using t…
c6e39e1 
…oBuilder = true
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] reorder constants based on vis…
c57477c 
…ibility
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] simplify
f0f30d0 
- inline method withProcessingError
- use the new helper methods from ProcessingErrorBuilder
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] rename variable for better rea…
84aa7d9 
…dability
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] simplify string construction
1e0cf3e
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add bpn to timeout ex…
c047ffb 
…ception message
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] extract code to method
ea86a63
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] correct exception hierarchy of…
40f1f2a 
… UsagePolicy*Exception

Reason: These exceptions both have the same attributes. Making the PolicyException interface a base class and moving the attributes there simplifies exception handling allowing to deal with both exceptions in the same way without casting / type checking.
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 30, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] missing import
aead813
@dsmf dsmf mentioned this issue Jul 30, 2024
Merged
2 tasks
@dsmf
Copy link
Contributor

dsmf commented Jul 30, 2024 •
edited
Loading

PR with some cleanup first

PR for actual fix

dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] remove obsolete method
b8a3255
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] increase visibility of getRoot…
39780ce 
…ErrorMessages
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] mark unhandy construction meth…
3cef700 
…ods as deprecated

use builder instead, even though this will be more eloquent it will be more flexible and easier to understand and change
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] add bpn and edcUrl attributes …
a95e960 
…to EdcRetrieverException, add builder
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] simplify builder for EdcReceiv…
f2d88aa 
…erException

single field builder and private setters in the class are sufficient here and reduce amount of boilerplate code
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] Fixes, improvements, …
543daf6 
…test

- Use the new EdcRetrieverException.Builder.
- Add endpoint url(s) and BPN in some places.
- Enhance tests.
- Remove the constructor methods Tombstone.from. Builder is used now.
- General code cleanup and formatting improvements across multiple test and implementation classes to enhance readability and maintainability including extraction of code to methods.
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
chore(quality): [eclipse-tractusx#841] formatting
dd74856
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] make constructor priv…
9ea3551 
…ate (builder)
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add bpn to validation…
2fe49e9 
… tombstone
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add assertions, impro…
7778cc4 
…ve test readability
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] fix PMD warning
5290a25
@dsmf dsmf mentioned this issue Aug 1, 2024
Merged
2 tasks
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] remove obsolete todos
1c4ab9e
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 1, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] fix test
b6fd328
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add prepareEmptyCatalog
6e309ad
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add successfulDiscovery
fef51fc
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add methods for multi…
147f701 
…ple edc urls
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] remove todo
d3c8af7
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add test
d89603b
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add todo
76d22fa
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] PMD
d6f6920
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] fix getRootErrorMessages
913d0a6
@dsmf dsmf mentioned this issue Aug 2, 2024
Closed
2 tasks
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] fix checkstyle warning
1a6a677 
replace tabs with spaces
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] improve test
5ed2f89
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] fix compile error
13a23e6
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add changelog entry
e947268
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] use unused method
bbe6fef
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Aug 2, 2024
@dsmf
fix(exception-handling): [eclipse-tractusx#841] resolve todo
5715943
@dsmf dsmf moved this from wip to test in IRS Aug 5, 2024
@ds-jhartmann
Copy link
Contributor

Fixed cucumber test in #866
Tested and works as expected. BPN and endpointURL are now filled for Tombstones during the Digital Twin request step

@ds-jhartmann ds-jhartmann moved this from test to review in IRS Aug 5, 2024
@mkanal mkanal moved this from review to done in IRS Aug 6, 2024
@mkanal mkanal closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmf dsmf

Labels
bug Something isn't working R24.8
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsmf @ds-jhartmann @mkanal