-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET irs/policies should not return BPNLs without policies #533
Labels
bug
Something isn't working
policy_store
Issues regarding the IRS policy store.
R24.5
release-hot-fix
pbi is relevant for current release and for hotfix path
Comments
6 tasks
1 task
Pull Request
|
ready for peer review |
ds-jhartmann
pushed a commit
that referenced
this issue
May 13, 2024
ds-jhartmann
pushed a commit
that referenced
this issue
May 13, 2024
Hi @mkanal, @ds-kgassner , deployed on DEV, ready for test |
PO acceptance in behalf of @jzbmw |
mkanal
added
R24.5
release-hot-fix
pbi is relevant for current release and for hotfix path
labels
May 13, 2024
2 tasks
ds-jhartmann
pushed a commit
that referenced
this issue
May 13, 2024
#533 broke integration tests because now an empty BPNL is not returned anymore => NPE in tests
ds-jhartmann
pushed a commit
that referenced
this issue
May 13, 2024
ds-jhartmann
pushed a commit
to ds-jhartmann/item-relationship-service
that referenced
this issue
Jun 13, 2024
…XX-fix-reset-env-script feat(impl):[TRI-XXX] fix reset env script - encode id to base64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
policy_store
Issues regarding the IRS policy store.
R24.5
release-hot-fix
pbi is relevant for current release and for hotfix path
As ... ,
I want that after DELETE / UPDATE policies each BPN which does not have any policies anymore is removed from the store,
so that GET irs/policies does not return BPN's that have no policies.
Hints / Details
Currently it looks like this:
Filtering BPN's without policies for GET policies requests is prepared in the following branch: 533-get-policies-filter-out-empty) BUT we should do a real cleanup on DELETE / UPDATE policies instead, so the business partner numbers without policies are removed from the policy store.
(see PolicyStoreServiceTest.getAllStoredPolicies_whenNoPoliciesAtAll_shouldReturnTheConfiguredDefaultPolicies in branch 533-get-policies-filter-out-empty and Discuss Default Policy Behaviour for not existing BPNL #535)
Acceptance Criteria
GET irs/policies
must return only BPN's that have policies.GET irs/policies?businessPartnerNumbers=<a BPN without policies i.e. not existing in policy store>
must return emptyOut of Scope
The text was updated successfully, but these errors were encountered: