Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTING] Integration Tests Policy Store (Unhappy Path) #519

Closed
7 tasks done
mkanal opened this issue Apr 4, 2024 · 8 comments
Closed
7 tasks done

[TESTING] Integration Tests Policy Store (Unhappy Path) #519

mkanal opened this issue Apr 4, 2024 · 8 comments
Assignees
@dsmf @mkanal
Labels
policy_store Issues regarding the IRS policy store. spill_over Issues which are not finished yet testing all testing related topics

Comments

@mkanal
Copy link
Contributor

mkanal commented Apr 4, 2024 •
edited
Loading

As product
I want automatically executed integration tests for policy store covering although the unhappy path
so that we are informed about regression errors at the earliest stage, and we have a high level of confidence in the application

Links

Hints / Details

Acceptance Criteria

  • Integration tests (Cucumber or Tavern) covering policy store unhappy path executed in Ci/CD pipeline before PR is merged
  • Test covers journey
    • Registration of policy with no validUntil > Should fail
    • Registration of policy for invalid BPN "BPNACB", "ERRRES", "DELETE * FROM Table" > Should fail
    • Registration of policy with no payload (poilicy) should fail
  • Registration of BPNA and BPNS number fails
    • Validation failes for BPNA and BPNS number

Out of Scope

  • ...
@github-project-automation github-project-automation bot moved this to inbox in IRS Apr 4, 2024
@mkanal mkanal added the testing all testing related topics label Apr 9, 2024
@mkanal mkanal changed the title [TEST] Integration Tests Policy Store (Unhappy Path) [TESTING] Integration Tests Policy Store (Unhappy Path) Apr 9, 2024
@dsmf
Copy link
Contributor

dsmf commented Apr 24, 2024

also relates to #518

@mkanal mkanal added the policy_store Issues regarding the IRS policy store. label Apr 24, 2024
@mkanal mkanal mentioned this issue Apr 24, 2024
Closed
6 tasks
@dsmf
Copy link
Contributor

dsmf commented Apr 24, 2024

is blocked by #528

This was referenced Apr 24, 2024
Open
Closed
Open
@mkanal mkanal moved this from inbox to backlog in IRS May 8, 2024
@dsmf
Copy link
Contributor

dsmf commented May 10, 2024 •
edited
Loading

Outcome

Solved partly by #518 and #528 already.

Pull Request

@dsmf dsmf self-assigned this May 10, 2024
@dsmf dsmf moved this from backlog to wip in IRS May 10, 2024
@dsmf dsmf mentioned this issue May 10, 2024
Merged
2 tasks
@dsmf
Copy link
Contributor

dsmf commented May 11, 2024

ready for peer review

ds-jhartmann pushed a commit that referenced this issue May 13, 2024
@dsmf
feat(impl): [#519] test steps for bad case registering policy without…
8c07fb2 
… payload
ds-jhartmann pushed a commit that referenced this issue May 13, 2024
@dsmf
feat(impl): [#519] add test step definitions
d71eb65
ds-jhartmann pushed a commit that referenced this issue May 13, 2024
@dsmf
feat(impl): [#519] correct CHANGELOG.md
f54b889
ds-jhartmann added a commit that referenced this issue May 13, 2024
@ds-jhartmann
Revert "feat(impl): [#519] correct CHANGELOG.md"
5d55d38 
This reverts commit f54b889
ds-jhartmann added a commit that referenced this issue May 13, 2024
@ds-jhartmann
Revert "feat(impl): [#519] add test step definitions"
81609a7 
This reverts commit d71eb65.
ds-jhartmann added a commit that referenced this issue May 13, 2024
@ds-jhartmann
Revert "feat(impl): [#519] test steps for bad case registering policy…
d6d90b7 
… without payload"

This reverts commit 8c07fb2.
@ds-jhartmann ds-jhartmann mentioned this issue May 13, 2024
Closed
2 tasks
@dsmf dsmf moved this from wip to test in IRS May 13, 2024
@dsmf
Copy link
Contributor

dsmf commented May 13, 2024

@mkanal, @ds-kgassner -> ready for test

@ds-kgassner
Copy link
Contributor

Registration of policy with no validUntil > Should fail: --> tested successfully
Registration of policy for invalid BPN "BPNACB", "ERRRES", "DELETE * FROM Table" --> tested successfully
Registration of BPNA and BPNS number fails: --> tested successfully
Registration of policy with no payload (poilicy) should fail: --> tested successfully
additionally: Fetching policies by BPNLs should fail for invalid BPNLs: --> tested successfully

approved from my side

@mkanal mkanal added the spill_over Issues which are not finished yet label May 14, 2024
@dsmf
Copy link
Contributor

dsmf commented May 14, 2024

@mkanal -> ready for PO review

@dsmf dsmf moved this from test to review in IRS May 14, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jun 5, 2024

LGFM: PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed Jun 5, 2024
@mkanal mkanal moved this from review to done in IRS Jun 5, 2024
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
@ds-jhartmann
Merge pull request eclipse-tractusx#519 from catenax-ng/feature/TRI-1…
3f275ae 
…548-add-cucumber-workflow

Feature/tri 1548 add cucumber workflow
@dsmf dsmf mentioned this issue Jun 13, 2024
Closed
This was referenced Jul 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmf dsmf

@mkanal mkanal

Labels
policy_store Issues regarding the IRS policy store. spill_over Issues which are not finished yet testing all testing related topics
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsmf @mkanal @ds-kgassner