Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileHeader template differs from .config/irs.header #303

Closed
dsmf opened this issue Nov 21, 2023 · 3 comments · Fixed by #346
Closed

FileHeader template differs from .config/irs.header #303

dsmf opened this issue Nov 21, 2023 · 3 comments · Fixed by #346
Assignees
Labels
bug Something isn't working linked_to_feature Issue is linked to a feature

Comments

@dsmf
Copy link
Contributor

dsmf commented Nov 21, 2023

https://github.com/catenax-ng/tx-item-relationship-service/blob/main/.idea/fileTemplates/includes/File%20Header.java
differs from
https://github.com/catenax-ng/tx-item-relationship-service/blob/main/.config/irs.header

image

Hints

FileTemplate does not seem to be working in IntelliJ. Make sure the template is located in the correct folder and in the right structure.

@dsmf dsmf added this to IRS Nov 21, 2023
@dsmf dsmf converted this from a draft issue Nov 21, 2023
@dsmf dsmf added the bug Something isn't working label Nov 21, 2023
@jzbmw jzbmw moved this from backlog to next in IRS Dec 12, 2023
@ds-jhartmann
Copy link
Contributor

Planning 2

  • Make sure that the file header is up to date
  • find out if the file template configuration is working in IntelliJ (fix if possible, remove if not)

@dsmf
Copy link
Contributor Author

dsmf commented Dec 12, 2023

When I set up the project in IntelliJ during onboarding the "File Header.java" was not automatically configured in IntelliJ. It appeared under Settings / Editor / File and Code Templates but it was not applied when new files were created. I had to set it up via settings / Editor / Copyright and there it was not possible to just copy and paste the contents because here the comment signs have to be omitted. So we should investigate how to set this up, so it is used automatically.

@ds-jhartmann ds-jhartmann self-assigned this Dec 14, 2023
@ds-jhartmann ds-jhartmann moved this from next to wip in IRS Dec 14, 2023
@ds-jhartmann
Copy link
Contributor

  • Moved from FileTemplate to Copyright IntelliJ settings
  • Added new license header which only includes the Eclipse Foundation Copyright
  • Checkstyle template adjusted to accept both the old and the new license header

PR: catenax-ng#697

@ds-jhartmann ds-jhartmann moved this from wip to review in IRS Dec 14, 2023
@ds-jhartmann ds-jhartmann moved this from review to done in IRS Dec 21, 2023
ds-jhartmann added a commit that referenced this issue Dec 21, 2023
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants