Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESS][SUPPLY-CHAIN_ACT][TOP DOWN APPROACH] Return the number of hops (relative distance in the supply chain) to an event from the requester's perspective. #246

Closed
jzbmw opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels
ess ess related topics linked_to_feature Issue is linked to a feature

Comments

@jzbmw
Copy link
Contributor

jzbmw commented Oct 31, 2023

USE THIS AS REFERENCE
https://jira.catena-x.net/browse/TRI-1641

@jzbmw jzbmw added this to IRS Oct 31, 2023
@jzbmw jzbmw converted this from a draft issue Oct 31, 2023
@jzbmw jzbmw moved this from backlog to review in IRS Oct 31, 2023
@jzbmw jzbmw changed the title ⭐👍 [ESS][SUPPLY-CHAIN_ACT][TOP DOWN APPROACH] Return the number of hops (relative distance in the supply chain) to an event from the requester's perspective. [ESS][SUPPLY-CHAIN_ACT][TOP DOWN APPROACH] Return the number of hops (relative distance in the supply chain) to an event from the requester's perspective. Nov 2, 2023
@jzbmw jzbmw added the ess ess related topics label Nov 2, 2023
@ds-alexander-bulgakov
Copy link
Contributor

During QA-review on branch TRI-1658-infected-supply-chain-on-first-tier-level hops could not be reproduced as expected. The number is always "1". See e.g. request for "Vehicle A" from testdataset ESS 2.0.0 which should be response with "hops = 4":
"submodels": [ { "identification": null, "aspectType": "supply_chain_impacted", "payload": { "supplyChainImpacted": "Yes", "impactedSuppliersOnFirstTier": [ { "bpnl": "BPNL00ARBITRARY1", "hops": 1 } ] } } ]
@ds-ext-kmassalski could you please have a look once again?

@ds-alexander-bulgakov ds-alexander-bulgakov moved this from review to wip in IRS Nov 7, 2023
@ds-psosnowski ds-psosnowski moved this from wip to review in IRS Nov 17, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 21, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 21, 2023
…west level of hops, code clean up, added test
ds-jhartmann pushed a commit that referenced this issue Nov 21, 2023
…ply-chain-on-first-tier-level

feat(impl):[#244] Show infected supply chain on first tier level + feat(impl):[#246] Show hops number for impacted supply chain
@ds-alexander-bulgakov
Copy link
Contributor

ds-alexander-bulgakov commented Nov 22, 2023

No more issues could be found during QA-review. hops are detected correct now. See example for request
{ "key": { "globalAssetId": "urn:uuid:0733946c-59c6-41ae-9570-cb43a6e4c79e", "bpn": "BPNL00000003AYRE" }, "incidentBPNSs": ["BPNS00000003B6LU"], "bomLifecycle": "asPlanned" }
with response and shortest node:
"submodels": [ { "identification": null, "aspectType": "supply_chain_impacted", "payload": { "supplyChainImpacted": "Yes", "impactedSuppliersOnFirstTier": { "bpnl": "BPNL00ARBITRARY1", "hops": 2 }
image

See outcome:

  • Requestor gets the number of hops which are in between the incident and himself in the supply chain.
  • Hops of shortest path is detected correctly for cases with several nodes with infected parts.
  • Tavern tests have been implemented. See JIRA tickets TRI-1761, TRI-1762, TRI-1763.

Ticket is ready for PO-review. FYI @jzbmw

@jzbmw jzbmw removed the PO Review label Nov 24, 2023
@jzbmw jzbmw self-assigned this Nov 27, 2023
@jzbmw jzbmw moved this from review to done in IRS Nov 27, 2023
@jzbmw jzbmw closed this as completed Nov 27, 2023
@mkanal mkanal assigned ds-psosnowski and unassigned jzbmw Nov 28, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 28, 2023
…ply-chain-on-first-tier-level

Feature/[#244,#246] Tavern tests for ESS impactedSupplierOnFirstTier hops and bpnl
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ess ess related topics linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

5 participants