Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Product-Lock KeyCloack from Documentation and HelmCharts #201

Closed
6 of 7 tasks
jzbmw opened this issue Oct 23, 2023 · 6 comments
Closed
6 of 7 tasks

Remove Product-Lock KeyCloack from Documentation and HelmCharts #201

jzbmw opened this issue Oct 23, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request linked_to_feature Issue is linked to a feature

Comments

@jzbmw
Copy link
Contributor

jzbmw commented Oct 23, 2023

As we are using OAuth2 Standard to authorize IRS and the API we have actually a product-lock in the configuration, documentation and in helm charts configuration. This might be removed to have a more generic approach.

Hints / Details

Current

keycloak:
  oauth2:
    clientId: <keycloak-client-id>
    clientSecret: <keycloak-client-secret>
    clientTokenUri: <keycloak-token-uri>
    jwkSetUri: <keycloak-jwkset-uri>

Expected

oauth2:
  clientId: "" #<oauth2.clientId>
  clientSecret: "" #<oauth2.clientSecret>
  clientTokenUri: "" #<oauth2.clientTokenUri>
  jwkSetUri: "" #<oauth2.jwkSetUri>
  resourceClient: "" #<oauth2.resourceClient>

Tasks

  • Rename all variables keycloak to oauth2
  • Source: Helm Charts, Configuration, Product documentation, Admin Manual, ARC42. a.s.o.
  • document in a separate chapter that any oauth service can be attached and how to do that.

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  • helm chart can be deployed successfully
  • documentation has been added
  • Keycloak vendor-lock is removed from docu, deployment etc. OAuth2 is used in code and deployment + docu

Out of Scope

  • ...

Sprint Planning 2

Currently

 clientId: <path:traceability-irs/data/dev/keycloak/oauth2#clientId>
      clientSecret: <path:traceability-irs/data/dev/keycloak/oauth2#clientSecret>
      clientTokenUri: <path:traceability-irs/data/dev/keycloak/oauth2#tokenUri>
      jwkSetUri: <path:traceability-irs/data/dev/keycloak/oauth2#jwkSetUri>

Expected

 clientId: <path:traceability-irs/data/dev/oauth2#clientId>
      clientSecret: <path:traceability-irs/data/dev/oauth2#clientSecret>
      clientTokenUri: <path:traceability-irs/data/dev/oauth2#tokenUri>
      jwkSetUri: <path:traceability-irs/data/dev/oauth2#jwkSetUri>
@jzbmw jzbmw added this to IRS Oct 23, 2023
@jzbmw jzbmw converted this from a draft issue Oct 23, 2023
@jzbmw jzbmw added ess ess related topics and removed ess ess related topics labels Oct 23, 2023
@jzbmw jzbmw moved this from inbox to backlog in IRS Oct 23, 2023
@jzbmw jzbmw added the enhancement New feature or request label Oct 31, 2023
@jzbmw jzbmw moved this from backlog to next in IRS Oct 31, 2023
@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Nov 2, 2023
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Nov 2, 2023
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to review in IRS Nov 6, 2023
@ds-ext-kmassalski
Copy link
Contributor

Waiting for:
eclipse-tractusx/sig-infra#342

@mkanal mkanal changed the title Remove Product-Lock KeyCloack from Documentation and HelmCharts [PO_REVIEW] Remove Product-Lock KeyCloack from Documentation and HelmCharts Nov 13, 2023
@ds-jhartmann ds-jhartmann changed the title [PO_REVIEW] Remove Product-Lock KeyCloack from Documentation and HelmCharts Remove Product-Lock KeyCloack from Documentation and HelmCharts Nov 14, 2023
@mkanal
Copy link
Contributor

mkanal commented Nov 15, 2023

Hi @ds-ext-kmassalski & @ds-alexander-bulgakov
what is missing is the outcome. Was this tested. How could this be tested? Is there some evidence to check? Need some assistance here. Thank you very much,

@ds-alexander-bulgakov
Copy link
Contributor

Hi @ds-ext-kmassalski,
as discussed please make sure the changes are deployt on DEV so i can test. Please give me a hint once the deployment is done. Thank you!

@ds-ext-kmassalski
Copy link
Contributor

Updated documentation without any 'Keycloak' mentions can be found here:
https://catenax-ng.github.io/tx-item-relationship-service/docs/arc42/full.html
OAuth2 protocol is used as substitute.

@mkanal mkanal removed the PO Review label Nov 16, 2023
@ds-ext-kmassalski
Copy link
Contributor

App deployed on DEV and INT with newest version (without keycloak configuration names).

Some more evidences that its was modified:

image

image

image

@ds-alexander-bulgakov
Copy link
Contributor

ds-alexander-bulgakov commented Nov 22, 2023

No issues could be found during final QA-review. For testing tavern and cucumber tests were run in gitlab and locally and IRS-jobs were requested on DEV. Docu was checked as well. See outcome:

Ticket is ready for PO-review. FYI @jzbmw

@jzbmw jzbmw removed the PO Review label Nov 24, 2023
@jzbmw jzbmw self-assigned this Nov 27, 2023
@jzbmw jzbmw moved this from review to done in IRS Nov 27, 2023
@jzbmw jzbmw closed this as completed Nov 27, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 28, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 28, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 28, 2023
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
Update Helm repository to tractus-x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

5 participants