Skip to content

Commit

Permalink
docs(testing):[#344] Add issue id to todos
Browse files Browse the repository at this point in the history
  • Loading branch information
ds-jhartmann committed Feb 2, 2024
1 parent d323587 commit c7c4aaf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void shouldReturnEmptyOnNotFound() {
bpdmWillNotFindCompanyName(bpn);

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatExceptionOfType(HttpClientErrorException.class).isThrownBy(
() -> bpdmFacade.findManufacturerName(bpn));
verifyBpdmWasCalledWithBPN(bpn, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void shouldThrowHttpClientExceptionInCaseOfDiscoveryError() {
final List<DigitalTwinRegistryKey> testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN));

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf(
HttpClientErrorException.class);
verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));
Expand All @@ -136,7 +136,7 @@ void shouldThrowHttpClientExceptionInCaseOfEdcDiscoveryError() {
final List<DigitalTwinRegistryKey> testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN));

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf(
HttpClientErrorException.class);
verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));
Expand All @@ -152,7 +152,7 @@ void shouldThrowHttpClientExceptionInCaseOfLookupShellsError() {
final List<DigitalTwinRegistryKey> testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN));

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf(
HttpClientErrorException.class);
verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));
Expand All @@ -170,7 +170,7 @@ void shouldThrowHttpClientExceptionInCaseOfShellDescriptorsError() {
final List<DigitalTwinRegistryKey> testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN));

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf(
HttpClientErrorException.class);
verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));
Expand All @@ -189,7 +189,7 @@ void shouldThrowExceptionOnEmptyShells() {
final List<DigitalTwinRegistryKey> testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN));

// Act & Assert
// TODO fix implementation to not throw HttpClientErrorException$NotFound
// TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound
assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf(
HttpClientErrorException.class);
verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));
Expand Down

0 comments on commit c7c4aaf

Please sign in to comment.