Skip to content

Commit

Permalink
feat(imp):[#214] Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
dsmf committed Jan 31, 2024
1 parent 8aa4c4b commit a6e4288
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ private Collection<String> lookupShellIds(final String bpn) throws RegistryServi
} catch (RuntimeException e) {
// catching generic exception is intended here,
// otherwise Jobs stay in state RUNNING forever
log.error(logPrefix + e.getMessage(), e); // TODO (mfischer) #214 do not log and throw
log.error(logPrefix + e.getMessage(), e);
final var msg = logPrefix + e.getClass().getSimpleName()
+ " occurred while looking up shell ids for bpn '%s'".formatted(bpn);
throw new RegistryServiceException(msg, e);
Expand All @@ -298,12 +298,12 @@ private Collection<String> lookupShellIds(final String bpn,

} catch (InterruptedException e) {
log.error(logPrefix + "InterruptedException occurred while looking up shells ids for bpn '%s': ".formatted(
bpn) + e.getMessage(), e); // #214 do not log and throw
bpn) + e.getMessage(), e);
Thread.currentThread().interrupt();
throw new RegistryServiceException(LOGPREFIX_TO_BE_REMOVED_LATER + e.getClass().getSimpleName()
+ " occurred while looking up shell ids for bpn '%s'".formatted(bpn), e);
} catch (ExecutionException e) {
log.error(logPrefix + e.getMessage(), e); // TODO (mfischer) #214 do not log and throw
log.error(logPrefix + e.getMessage(), e);
throw new RegistryServiceException(LOGPREFIX_TO_BE_REMOVED_LATER + e.getClass().getSimpleName()
+ " occurred while looking up shell ids for bpn '%s'".formatted(bpn), e);
}
Expand Down

0 comments on commit a6e4288

Please sign in to comment.