feat(irs-apiirs-edc-client):[#256] removed dependency

eclipse-tractusx · Dec 4, 2023 · 9654457 · 9654457
1 parent 2495ac1
commit 9654457
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 16 deletions.
diff --git a/irs-edc-client/pom.xml b/irs-edc-client/pom.xml
@@ -225,17 +225,6 @@
             <version>${awaitility.version}</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>com.google.code.findbugs</groupId>
-            <artifactId>annotations</artifactId>
-            <version>${findbug.version}</version>
-        </dependency>
-        <dependency>
-            <groupId>com.google.code.findbugs</groupId>
-            <artifactId>jsr305</artifactId>
-            <version>3.0.1</version>
-            <scope>provided</scope>
-        </dependency>
     </dependencies>
 
 </project>
diff --git a/...-client/src/main/java/org/eclipse/tractusx/irs/edc/client/ContractNegotiationService.java b/...-client/src/main/java/org/eclipse/tractusx/irs/edc/client/ContractNegotiationService.java
@@ -69,9 +69,6 @@ public NegotiationResponse negotiate(final String providerConnectorUrl, final Ca
     }
 
     @SuppressWarnings("PMD.AvoidReassigningParameters")
-    @edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
-            value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE",
-            justification = "Not reachable code")
     public NegotiationResponse negotiate(final String providerConnectorUrl, final CatalogItem catalogItem,
             EndpointDataReferenceStatus endpointDataReferenceStatus)
             throws ContractNegotiationException, UsagePolicyException, TransferProcessException {

diff --git a/...main/java/org/eclipse/tractusx/irs/edc/client/util/EndpointDataReferenceCacheService.java b/...main/java/org/eclipse/tractusx/irs/edc/client/util/EndpointDataReferenceCacheService.java
@@ -82,7 +82,6 @@ private Optional<EndpointDataReference> retrieveEndpointEndpointReferenceByAsset
         return endpointDataReferenceStorage.get(assetId);
     }
 
-    @edu.umd.cs.findbugs.annotations.SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private static boolean isTokenExpired(final EndpointDataReference endpointDataReference) {
         final Instant tokenExpirationInstant = extractTokenExpiration(endpointDataReference.getAuthCode());
         return Instant.now().isAfter(tokenExpirationInstant);

diff --git a/pom.xml b/pom.xml
@@ -105,7 +105,6 @@
         <junit-jupiter-engine.version>5.9.2</junit-jupiter-engine.version>
         <json-smart.version>2.4.10</json-smart.version>
         <testcontainers-bom.version>1.19.1</testcontainers-bom.version>
-        <findbug.version>3.0.1</findbug.version>
 
         <!-- Plugins -->
         <spotbugs-plugin.version>4.7.3.2</spotbugs-plugin.version>