feat(imp):[#214] improve readability

eclipse-tractusx · Jan 18, 2024 · 8137cd2 · 8137cd2
1 parent 6a117dd
commit 8137cd2
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java b/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java
@@ -64,14 +64,12 @@ public <T> CompletableFuture<T> getFastestResult(final List<CompletableFuture<T>
 
         final List<Throwable> exceptions = new ArrayList<>();
 
-        final var handledFutures = //
-                toArray(futures.stream()
-                               .map(future -> future.exceptionally(
-                                                            completingExceptionallyCollectingException(exceptions))
-                                                    .handle(completingOnFirstSuccessful(fastestResultPromise)))
-                               .toList());
+        final var futuresList = futures.stream()
+                                       .map(future -> future.exceptionally(collectingExceptionsAndThrow(exceptions))
+                                                            .handle(completingOnFirstSuccessful(fastestResultPromise)))
+                                       .toList();
 
-        allOf(handledFutures).whenComplete((value, ex) -> {
+        allOf(toArray(futuresList)).whenComplete((value, ex) -> {
 
             log.debug("List of futures completed");
 
@@ -118,8 +116,7 @@ private static <T> BiFunction<T, Throwable, Boolean> completingOnFirstSuccessful
         };
     }
 
-    private static <T> Function<Throwable, T> completingExceptionallyCollectingException(
-            final List<Throwable> exceptions) {
+    private static <T> Function<Throwable, T> collectingExceptionsAndThrow(final List<Throwable> exceptions) {
         return t -> {
             log.error("Exception occurred: " + t.getMessage(), t);
             exceptions.add(t);