feat(impl):[#341] fix property name, fix readme description, move def…

…ault to config
eclipse-tractusx · Mar 20, 2024 · 3d957b9 · 3d957b9
1 parent 42b0abd
commit 3d957b9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/irs-api/src/main/resources/application.yml b/irs-api/src/main/resources/application.yml
@@ -129,7 +129,7 @@ resilience4j:
         baseConfig: default
 
 irs-edc-client:
-  callback-url: ${EDC_TRANSFER_CALLBACK_URL:} # The URL where the EDR token callback will be sent to.
+  callback-url: ${EDC_TRANSFER_CALLBACK_URL:/internal/endpoint-data-reference} # The URL where the EDR token callback will be sent to.
   asyncTimeout: PT10M # Timout for future.get requests as ISO 8601 Duration
   controlplane:
     request-ttl: ${EDC_CONTROLPLANE_REQUEST_TTL:PT10M} # How long to wait for an async EDC negotiation request to finish, ISO 8601 Duration

diff --git a/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java b/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java
@@ -40,7 +40,7 @@
  */
 @Slf4j
 @RestController("irsEdcClientEdcCallbackController")
-@RequestMapping("${irs-edc-client.callback.mapping:internal/endpoint-data-reference}")
+@RequestMapping("/${irs-edc-client.callback-url}")
 @Hidden
 @RequiredArgsConstructor
 public class EdcCallbackController {

diff --git a/irs-registry-client/README.md b/irs-registry-client/README.md
@@ -38,7 +38,7 @@ digitalTwinRegistryClient:
   lookupShellsTemplate: /lookup/shells?assetIds={assetIds} # The path to lookup shells from the DTR. Required if type is "decentral", must contain the placeholder {assetIds}
 
 irs-edc-client:
-  callback-url: "" # The URL where the EDR token callback will be sent to. This defaults to {BASE_URL}/internal/endpoint-data-reference. If you want to use a different mapping, you can override it with irs-edc-client.callback.mapping.
+  callback-url: "" # The URL where the EDR token callback will be sent to. This defaults to {BASE_URL}/internal/endpoint-data-reference.
   asyncTimeout: PT10M # Timout for future.get requests as ISO 8601 Duration  
   controlplane:
     request-ttl: PT10M # How long to wait for an async EDC negotiation request to finish, ISO 8601 Duration