Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCM-KIT for Release 24.08 #969

Closed
wants to merge 60 commits into from
Closed

DCM-KIT for Release 24.08 #969

wants to merge 60 commits into from

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Jul 8, 2024

Description

This PR contains the DCM-Kit for release 24.08.
Only the DCM-KIT (and links to the DCM KIT) are affected by this PR
image
Figure: Changed Files

The following issues are addressed.

eclipse-tractusx/sig-release#587
eclipse-tractusx/sig-release#585
eclipse-tractusx/sig-release#608

https://github.com/catenax-eV/cx-ex-dcm/issues/14
https://github.com/catenax-eV/cx-ex-dcm/issues/21
https://github.com/catenax-eV/cx-ex-dcm/issues/12
https://github.com/catenax-eV/cx-ex-dcm/issues/7
https://github.com/catenax-eV/cx-ex-dcm/issues/10

Some highlites:

  • Added missing license information (TRG.7.08)
  • Introduced Swagger API documentation
  • Introduced Q&A
  • Refined On-Boarding
  • Restructured Kit
  • Added sections for Standard Add Ons

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Mai Philipp and others added 30 commits June 19, 2024 14:59
Add tmp folder for sharing API Swagger docs
- Fix Links
- Delete block-beta mermaid diagrams
Rearrange DCM KIT categories & pages
fix links in Adoption View overview
Extend Adoption View with subsection
- minor formattings
YAML description fixes & formatting fixes
Copy link

@jschu1 jschu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumps up @ClosedSourcerer

Copy link
Contributor

@nhaenis nhaenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work @ClosedSourcerer!

@nhaenis
Copy link
Contributor

nhaenis commented Jul 9, 2024

Updated links from https://catena-x.net/de/standard-library to https://catenax-ev.github.io/docs/next/standards/CX-0128-DemandandCapacityManagementDataExchange see #955

@ClosedSourcerer
Copy link
Contributor Author

ClosedSourcerer commented Jul 9, 2024

@evegufy
image

https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-00/#keep-the-following-updated-for-each-pull-request-to-the-default-branch-main

This is technically no CodeContribution, but just KIT as Documentation. Hence I assume that the 1000 line rule does not apply here.

@AngelikaWittek
Copy link
Contributor

@ClosedSourcerer

This is technically no CodeContribution, but just KIT as Documentation. Hence I assume that the 1000 line rule does not apply here.

The rule applies, please see: https://www.eclipse.org/projects/handbook/#ip-project-content
"The content contains more than 1,000 lines of content (including documentation, code, configuration files, and other forms of source code)."

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECA Check failed: https://api.eclipse.org/git/eca/status/gh/eclipse-tractusx/eclipse-tractusx.github.io/969

ECA is mandatory for Eclipse-Tractusx contributions.

@carslen
Copy link
Contributor

carslen commented Jul 10, 2024

The following issues are addressed.

[...]

https://github.com/catenax-eV/cx-ex-dcm/issues/14
https://github.com/catenax-eV/cx-ex-dcm/issues/21
https://github.com/catenax-eV/cx-ex-dcm/issues/12
https://github.com/catenax-eV/cx-ex-dcm/issues/7
https://github.com/catenax-eV/cx-ex-dcm/issues/10

To work open and transparent we shall not use/link to closed eco-systems in PRs in TractusX. I'm Committer of TractusX and unable to view these Issues thus I won't approve this PR.

@carslen
Copy link
Contributor

carslen commented Jul 10, 2024

Regarding ECA:

image That is my local account. After a GIT update i needed to reset my config, hence one or two commits were using my local account.

This might help: https://gist.github.com/trey/9588090

@danielmiehle
Copy link
Contributor

Just to sum it up:

  • Please resolve the ECA conflicts. Fix e-mails in commit history / squash commits if necessary
  • To ensure high-quality reviews, we would ask you to divide the PR into (reasonably) smaller PRs. This is good practice for both code and documentation reviews as described above.
  • Please execute the IP check by the Eclipse Foundation for this PR.
  • For the R24.08 KIT reviews, please add @jSchuetz88, as well as @maximilianong and me as reviewing committers (in addition to your business reviewers).
  • For future KIT reviews, you will need dedicated reviewing committers for your KIT. @jSchuetz88 @stephanbcbauer: Can you please add this information in the upcoming townhall meetings.

Thank you for your support and for adapting the open topics!

@ClosedSourcerer
Copy link
Contributor Author

There will be new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants