Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(products/repositories): adapt/update whole list of products/repositories #968

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

stephanbcbauer
Copy link
Member

@stephanbcbauer stephanbcbauer commented Jul 7, 2024

Description

The main purpose for this PR is to update our product list. It's old and not up to date. The initial idea was to publish all our active products in this list. Since we are always asking about the responsible committer for each repository, I tried to update the list for each repository depending on the committers' contribution to the repository.

What is needed in this PR @eclipse-tractusx/automotive-tractusx-committers, please have a look at your product, repositories or where you are listed as committer. Is this correct? Is there a description or something missing within your product? Should we describe something more in detail? Would be happy about your sugestions.

Goal

If this PR is merged (hopefully we can do this) we would have a list of all products/repositories and the related committer which is responsible for this product/repository.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer stephanbcbauer added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 7, 2024
@stephanbcbauer stephanbcbauer requested a review from a team July 7, 2024 19:08
@stephanbcbauer stephanbcbauer self-assigned this Jul 7, 2024
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed for puris / myself

utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
evegufy
evegufy previously requested changes Jul 8, 2024
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
@matbmoser
Copy link
Contributor

Ok, I have updated our Digital Product Pass product description and configurations. I also removed the eco pass kit repo, since it is not really a product and it is archived.

matbmoser
matbmoser previously approved these changes Jul 8, 2024
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least from my side I can approve the merge.

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this list was generated by a script or similar, it should maybe be re-run without taking archived repos into account.
I already suggested in the past, that if this list is maintained here, we should maybe automate it with the same logic as the TRG dashboard is generated: https://eclipse-tractusx.github.io/sig-release/
This dashboard already groups repos to products and also ignores archived repos. SIGs and supporting repos are also already separated.
Maybe both approaches (website + dashboard) can be combined, so that there is no duplication and manual effort.

@almadigabor and @tomaszbarwicki: Could you two please double check this PR explicitly? You are referenced in a lot of product, where I guess you did TRG checks or merged contributions. I guess you are not actually involved in all of the products

utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
@almadigabor
Copy link
Contributor

If this list was generated by a script or similar, it should maybe be re-run without taking archived repos into account. I already suggested in the past, that if this list is maintained here, we should maybe automate it with the same logic as the TRG dashboard is generated: https://eclipse-tractusx.github.io/sig-release/ This dashboard already groups repos to products and also ignores archived repos. SIGs and supporting repos are also already separated. Maybe both approaches (website + dashboard) can be combined, so that there is no duplication and manual effort.

@almadigabor and @tomaszbarwicki: Could you two please double check this PR explicitly? You are referenced in a lot of product, where I guess you did TRG checks or merged contributions. I guess you are not actually involved in all of the products

Hey @SebastianBezold, I had a look at the products where I'm listed as committer and added comments where I see fit.

@tunacicek
Copy link
Contributor

sldt topics LGTM

@stephanbcbauer
Copy link
Member Author

sldt topics LGTM

@tunacicek THX, just to confirm, also this comment?

The SLDT Topic was the only open Part. So if it is OK for you, I would be happy for a approval :) Maybe also from your side @matbmoser

@tunacicek
Copy link
Contributor

sldt topics LGTM

@tunacicek THX, just to confirm, also this comment?

The SLDT Topic was the only open Part. So if it is OK for you, I would be happy for a approval :) Maybe also from your side @matbmoser

@stephanbcbauer : Thanks for the feedback. I will take a look. Maybe it make sense as tom mention to separate the products in "semantic-layer & digital twin" and discovery services.

@stephanbcbauer
Copy link
Member Author

sldt topics LGTM

@tunacicek THX, just to confirm, also this comment?
The SLDT Topic was the only open Part. So if it is OK for you, I would be happy for a approval :) Maybe also from your side @matbmoser

@stephanbcbauer : Thanks for the feedback. I will take a look. Maybe it make sense as tom mention to separate the products in "semantic-layer & digital twin" and discovery services.

THX @tunacicek I will wait for feedback? Correct?

* digital twin registry
* semantic layer
* discovery services
@tunacicek
Copy link
Contributor

sldt topics LGTM

@tunacicek THX, just to confirm, also this comment?
The SLDT Topic was the only open Part. So if it is OK for you, I would be happy for a approval :) Maybe also from your side @matbmoser

@stephanbcbauer : Thanks for the feedback. I will take a look. Maybe it make sense as tom mention to separate the products in "semantic-layer & digital twin" and discovery services.

THX @tunacicek I will wait for feedback? Correct?

I separated the products into digital twin registry, semantic layer, and discovery services.
I hope this is fine.

matbmoser
matbmoser previously approved these changes Dec 19, 2024
@stephanbcbauer
Copy link
Member Author

@mhellmeier , @tom-rm-meyer-ISST you requested changes, we already adapted them. Is it OK for you to merge the PR for now? Would like to work on a clean state with beginning of the new year

mhellmeier
mhellmeier previously approved these changes Dec 19, 2024
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the changes!

@stephanbcbauer stephanbcbauer dismissed evegufy’s stale review December 19, 2024 08:06

we already changed your requests :)

tunacicek
tunacicek previously approved these changes Dec 19, 2024
utils/products.js Outdated Show resolved Hide resolved
utils/products.js Outdated Show resolved Hide resolved
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we missed to remove the identity-trust repo following my comments.

sidenote on the open collaboration: It's always good to leave a short notice on the comment like "done" if done. I resolved my comments and checcked on my own what's done.

Co-authored-by: Tom Meyer <[email protected]>
@stephanbcbauer stephanbcbauer dismissed stale reviews from mhellmeier and matbmoser via 630232a December 19, 2024 08:59
@stephanbcbauer
Copy link
Member Author

stephanbcbauer commented Dec 19, 2024

Hey, we missed to remove the identity-trust repo following my comments.

sidenote on the open collaboration: It's always good to leave a short notice on the comment like "done" if done. I resolved my comments and checcked on my own what's done.

Thx, normally i add a done, maybe i missed it somewhere since there were so many changes:
eg

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanbcbauer stephanbcbauer merged commit 47f9b32 into main Dec 19, 2024
5 checks passed
@stephanbcbauer stephanbcbauer deleted the chore/update-product-page branch December 19, 2024 10:48
@stephanbcbauer
Copy link
Member Author

Thank you, everybody … let's rework the list if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants