-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ecopass): fixed broken images bug in images svgs in compilation #934
Conversation
I dont know why but since I have sanitized the SVG I can not edit it with draw.io |
No dependency was added |
Ok this was fixed |
Thank you @arnoweiss for the support in solving the Dependency problem. I was thinking that the dash dependencies were updated with the 3rd party dependency pipeline automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build warnings are gone. There's a similar issue in the Modular Production Kit. Can you elaborate a bit on how you fixed this?
@arnoweiss there was a problem with the formating from the SVG files. I solved by recreating the images again in draw.io. Some of them probably is a export problem, people need to export the svgs correctly in Draw.io. Not "save as SVG" but "export as SVG" |
Description
There was a bug that was reported theissue below where broken images "svgs" were not possible to be compiled.
closes #930
What has changed?
Issues Fixed
Deleted
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: