Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecopass): fixed broken images bug in images svgs in compilation #934

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Jun 17, 2024

Description

There was a bug that was reported theissue below where broken images "svgs" were not possible to be compiled.

closes #930

What has changed?

Issues Fixed

  • Fixed dataRetrievalFlow image from Software View
  • Fixed value chain benefits image from Adoption View

Deleted

  • Removed images that were not in use (Old Architecture Diagram)

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@matbmoser matbmoser self-assigned this Jun 17, 2024
@matbmoser matbmoser added the bug Something isn't working label Jun 17, 2024
@matbmoser matbmoser linked an issue Jun 17, 2024 that may be closed by this pull request
@matbmoser matbmoser changed the title chore(ecopass): fixed bug in images svgs in compilation chore(ecopass): fixed broken images bug in images svgs in compilation Jun 17, 2024
@matbmoser matbmoser requested a review from arnoweiss June 17, 2024 12:37
@matbmoser
Copy link
Contributor Author

I dont know why but since I have sanitized the SVG I can not edit it with draw.io

@matbmoser
Copy link
Contributor Author

No dependency was added
just cloned from main

@matbmoser
Copy link
Contributor Author

I dont know why but since I have sanitized the SVG I can not edit it with draw.io

Ok this was fixed

@matbmoser
Copy link
Contributor Author

Thank you @arnoweiss for the support in solving the Dependency problem. I was thinking that the dash dependencies were updated with the 3rd party dependency pipeline automatically.

Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build warnings are gone. There's a similar issue in the Modular Production Kit. Can you elaborate a bit on how you fixed this?

@matbmoser
Copy link
Contributor Author

matbmoser commented Jun 25, 2024

@arnoweiss there was a problem with the formating from the SVG files. I solved by recreating the images again in draw.io. Some of them probably is a export problem, people need to export the svgs correctly in Draw.io. Not "save as SVG" but "export as SVG"

@matbmoser matbmoser merged commit ef1eee9 into main Jun 25, 2024
5 checks passed
@matbmoser matbmoser deleted the fix/ecopass_24-03 branch June 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Eco Pass] warning for broken images
3 participants