Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorials): Update prerequisites.md - minor changes #632

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

JohannesARENA2036
Copy link
Contributor

@JohannesARENA2036 JohannesARENA2036 commented Jan 23, 2024

Description

Added info for port 8080, correction of the shell command for generating the hashicorp key, some minor additions.

Closes #577

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Added info for port 8080, correction of the shell command for generating the hashicorp key, some minor additions.
@stephanbcbauer stephanbcbauer changed the title Update prerequisites.md - minor changes fix(tutorials): Update prerequisites.md - minor changes Jan 23, 2024
@stephanbcbauer stephanbcbauer added bug Something isn't working documentation Improvements or additions to documentation labels Jan 23, 2024
@awellnitz-materna awellnitz-materna self-requested a review January 23, 2024 19:12
stephanbcbauer
stephanbcbauer previously approved these changes Jan 24, 2024
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@florianrusch-zf florianrusch-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the linting error ;-)

@stephanbcbauer
Copy link
Member

@awellnitz-materna please review :) thx

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanbcbauer stephanbcbauer merged commit 8499c1e into eclipse-tractusx:main Feb 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(tutorials): Prerequisites Terraform - malformed shell command
4 participants