-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tutorials): Update prerequisites.md - minor changes #632
fix(tutorials): Update prerequisites.md - minor changes #632
Conversation
Added info for port 8080, correction of the shell command for generating the hashicorp key, some minor additions.
Co-authored-by: Alex Wellnitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Alex Wellnitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the linting error ;-)
Replacing specific hostname by variable
@awellnitz-materna please review :) thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added info for port 8080, correction of the shell command for generating the hashicorp key, some minor additions.
Closes #577
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: