Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add drawing as code trg as draft #401

Merged
merged 4 commits into from
Oct 10, 2023
Merged

chore: add drawing as code trg as draft #401

merged 4 commits into from
Oct 10, 2023

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Sep 19, 2023 •
edited
Loading

Description

  • add new trg as draft to alignment on diagrams as code
  • enhancing required documentation for our product repositories

updates eclipse-tractusx/sig-infra#87

Preview

image

Testing

  • checkout pr branch
  • npm install (optional)
  • npm start
  • verfiy changes

@FaGru3n FaGru3n mentioned this pull request Sep 19, 2023
Closed
10 tasks
florianrusch-zf
florianrusch-zf previously requested changes Sep 20, 2023
View reviewed changes
docs/release/trg-0/trg-1-4.md Outdated Show resolved Hide resolved
docs/release/trg-0/trg-1-4.md Outdated Show resolved Hide resolved
docs/release/trg-0/trg-1-4.md Outdated Show resolved Hide resolved
evegufy
evegufy previously requested changes Sep 20, 2023
View reviewed changes
docs/release/trg-0/trg-1-4.md Outdated Show resolved Hide resolved
docs/release/trg-0/trg-1-4.md Outdated Show resolved Hide resolved
@FaGru3n FaGru3n requested a review from evegufy September 20, 2023 13:53
@stephanbcbauer stephanbcbauer mentioned this pull request Sep 25, 2023
Closed
2 tasks
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love the workflows

stephanbcbauer
stephanbcbauer approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Its not part of this PR, but the initial presentation of these diagramms doesnt look good. Maybe we should rethink the theming and also add some functionality for zooming -> will create an issue for it)

@tom-rm-meyer-ISST
Copy link
Contributor

LGTM, love the workflows

I today had a point that came to my mind: Do we recommend tooling for mockups? The provided tools only apply on diagrams but if I would like to include a mockup, draw.io or pencil would be more appropriate.

@Siegfriedk
Copy link
Contributor

LGTM, love the workflows

I today had a point that came to my mind: Do we recommend tooling for mockups? The provided tools only apply on diagrams but if I would like to include a mockup, draw.io or pencil would be more appropriate.

Originally i wasn't aware how well draw.io would work as a 'online service'. I looked it up and its opensource.

If we discribe it properly (how to run draw.io locallly through docker) so that its easy to update from someone else and have the source files also checked in, than its a good option.

@FaGru3n FaGru3n dismissed florianrusch-zf’s stale review September 29, 2023 05:31

florianrusch-cluetec approved these changes

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Sep 29, 2023

@florianrusch-cluetec thanks for your approval so dissmissed your "request changes" if you would like to add more comments... i would appreciate them... 😉

@florianrusch-zf
Copy link
Contributor

florianrusch-zf commented Sep 29, 2023 •
edited
Loading

@florianrusch-cluetec thanks for your approval so dissmissed your "request changes" if you would like to add more comments... i would appreciate them... 😉

sorry, used the wrong account for the approval 😅

Didn't you already accepted all of my remarks? Sorry, misunderstood your message :D Yes, I will also approve with this account ;-)

@evegufy evegufy dismissed their stale review September 29, 2023 08:57

conversation resolved

@FaGru3n FaGru3n mentioned this pull request Oct 10, 2023
Closed
2 tasks
@FaGru3n
Copy link
Contributor Author

FaGru3n commented Oct 10, 2023

hi reviewer,

thanks for your input and help to understand how we can align together.

...will now merge the PR, because it will be still in drafting phase until it becomes mandatory for all our repositories. 😉

@FaGru3n FaGru3n merged commit b47a0b0 into main Oct 10, 2023
@florianrusch-zf
Copy link
Contributor

@FaGru3n cool that we merged it :-) Can we remove the branch? Or do you still need it?

@FaGru3n FaGru3n deleted the docs/diagram-as-code-trg-draft branch October 11, 2023 09:40
@FaGru3n
Copy link
Contributor Author

FaGru3n commented Oct 11, 2023

deleted my branches, are a lot for the hole repo... is there a clean-up rule for this repo?

@Siegfriedk
Copy link
Contributor

@FaGru3n i'm not aware of but we can PR a change that all branches get deleted when PR is done.

@FaGru3n FaGru3n mentioned this pull request Oct 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

@florianrusch-zf florianrusch-zf florianrusch-zf approved these changes

@stephanbcbauer stephanbcbauer stephanbcbauer approved these changes

@evegufy evegufy Awaiting requested review from evegufy

@Siegfriedk Siegfriedk Awaiting requested review from Siegfriedk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FaGru3n @tom-rm-meyer-ISST @Siegfriedk @florianrusch-zf @evegufy @stephanbcbauer