-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kit logos #1113
Update kit logos #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure there is no svg water mark. This usually happens when it was moved to PowerPoint
I moved it to Powerpoint --> no watermark --> all fine |
@matbmoser @jSchuetz88 @stephanbcbauer I just added kit-colors.md. Please review it as well. |
Could you provide me with the source for one or two of the images please? I randomly checked 10 of the newly added .svg files and noticed the following:
This lead me to have an indepth look into
Funnily enough:
BUT demand-and-capacity-management-kit-logo.drawio.svg is an svg with embedded PNG data. So at least partially it is not true vector graphic.
|
...c/img/kits/demand-and-capacity-management/demand-and-capacity-management-kit-logo.drawio.svg
Outdated
Show resolved
Hide resolved
Regarding the newly added: demand-and-capacity-management-kit-logo.drawio.svg in 92d1526 That file ist at least two-thirds data-garbage. I made a quick manual edit to it. I added roughly 3kb data by adding human readable formatting. The garbage mainly consist of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side now. Build and tested it.
From my perspective, regardless of whether you are right (on the technical level), I don't see any reason why we should discuss the generation of .svg files by .drawio (or any other established software) here. If we expect this from our contributors to check and fix on the data structure level, we most likely will never see a contribution again. Content wise, this PR is an improvement compared to the previous state, it cleans up the file-structure + it works fine and looks good. In addition, I wouldn't say it does not serve any purpose. I may be wrong here, but in my understanding, it is the "garbage" portion that allows the file to be edited in draw.io again by everyone else if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more discussions. Please merge ASAP.
Thank you @Grand-Thibault for your wonderful work!
dismissing review from @ClosedSourcerer since the changes were included by @Grand-Thibault! Thx guys. |
Because the changes are old, and they were implemented already.
I am merging this ASAP, if anything is missing please open another PR @ClosedSourcerer. The other kits logos are fine. Great job @Grand-Thibault 🚀 |
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: