Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(open-meetings): change CEST/CET where needed #1105

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

stephanbcbauer
Copy link
Member

Description

This PR changes the timezone in the open meetings to fit the related schedule. For the regular meetings, we have to switch again in March ;)

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer stephanbcbauer added the documentation Improvements or additions to documentation label Dec 3, 2024
@stephanbcbauer stephanbcbauer requested a review from a team December 3, 2024 11:06
@stephanbcbauer stephanbcbauer self-assigned this Dec 3, 2024
@stephanbcbauer stephanbcbauer marked this pull request as ready for review December 3, 2024 11:18
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having to change them every time could it worth to add a disclaimer explaining how to interpret those?

e.g.
in the schedule: Every Tuesday from 10:30 am to 11:00 am

just before the meeting list:

All the times are shown in:
- UTC+2 (CEST) between the last Sunday of March and the last Sunday of October
- UTC+1 (CET) the rest of the year.

(note aside: I would also switch to the 24hour format (without am-pm))

@stephanbcbauer stephanbcbauer requested review from a team and ndr-brt December 10, 2024 18:34
@stephanbcbauer
Copy link
Member Author

instead of having to change them every time could it worth to add a disclaimer explaining how to interpret those?

e.g. in the schedule: Every Tuesday from 10:30 am to 11:00 am

just before the meeting list:

All the times are shown in:
- UTC+2 (CEST) between the last Sunday of March and the last Sunday of October
- UTC+1 (CET) the rest of the year.

(note aside: I would also switch to the 24hour format (without am-pm))

thx. added the information. i didnt delete am/pm, since i was not sure what is the default way we should mention it. No hard feelings... but is this the official way to dsplay the time?

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx. added the information. i didnt delete am/pm, since i was not sure what is the default way we should mention it. No hard feelings... but is this the official way to dsplay the time?

I guess there's no official way, some countries use the AM/PM, while the rest of the world uses the 24h format.
As an engineer, I see the second one as definitely better, as it is clearer and leaves less space for misinterpretation. (same thoughts about the DD/MM vs MM/DD argument).
But, no strong feelings here, let's get it merged as it is ;)

@stephanbcbauer stephanbcbauer merged commit 630357d into main Dec 12, 2024
5 checks passed
@stephanbcbauer stephanbcbauer deleted the docs/change-timezone-open-meetings branch December 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants