Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (IC): Fixed two broken links to OpenAPI specification for Unique ID Push [GH-1068] #1104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markuskeidl
Copy link
Contributor

@markuskeidl markuskeidl commented Dec 3, 2024

Description

Fixes dead links in Industry Core KIT as reported here: #1068

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@markuskeidl
Copy link
Contributor Author

Not sure about the changelog - I created it in a way that this should go into 25.03. If we want to integrate it now, the entry has to be changed to release a version 1.2.1 or something like that.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @markuskeidl for fixing this issue. I have only one minor remark:

  • There seems to be a conflict with the changelog. The current version of the changelog is 1.3.0 (See here. As a Patch, the version of this change should be 1.3.1
  • Additionally, as this change fixes an issue which is also part of the R24.12 release. Could you also add this change to the R24.12 version? (./docs-kits_versioned_docs/version-24.12 /kits/...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants