-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example to trg 1.08 #1103
docs: add example to trg 1.08 #1103
Conversation
Example describes how to handle Interface documentation for the KITs
Dash runner failed because of http 429 "too many requests"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
usage: "Eclipse-tractusx website repository" | ||
url: "https://github.com/eclipse-tractusx/eclipse-tractusx.github.io" | ||
openApiSpecs: | ||
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/main/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future one could also think of creating tags in the website repo at every release to version the api specs (as far as I understood, currently only the kits documentation is "versioned" via a folder structure).
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/main/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml" | |
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/refs/tags/R25.03/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml" | |
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/refs/tags/R24.12/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review.
I agree that versioning the API references is a sensible and the only precise approach.
Afaik, currently all KITs do get "promoted" into the new release, even if there are 0 changes.
With the tagged approach updating the tags for the APIs would become a regular maintanance task that has to be performed every release.
As for the suggested changes:
Since tagging is currently not in place, integrating them would move the example away from the current reality and I want the example to reflect the current reality and not a, for now, unrealised utopia :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the suggested changed function just to make the possible future enhancement proposal more understandable and I didn't expect them to be implemented as part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Since we already have a planned feature for upgrading docusaurus and removing open-api plug-in and using the api-hub i just want to mention the reference to this TRG/PR eclipse-tractusx/sig-release#985
Description
This PR is supposed to enhance Tractus Release Guideline 1.08 by adding a concrete example for how to add API documentation to the KITs.
This has been discussed during the community hours on November 29th 2024:
https://github.com/orgs/eclipse-tractusx/projects/61/views/1?pane=issue&itemId=89121776
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: