Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example to trg 1.08 #1103

Merged

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Dec 2, 2024

Description

This PR is supposed to enhance Tractus Release Guideline 1.08 by adding a concrete example for how to add API documentation to the KITs.

This has been discussed during the community hours on November 29th 2024:

https://github.com/orgs/eclipse-tractusx/projects/61/views/1?pane=issue&itemId=89121776

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
    • No code has been added therefore dependencies should be unaffected by this PR
  • Copyright and license header are present on all affected files
    • There is neither a copyright nor license header for any of the TRGs.
      • I assume this is intended and have therefore not added copyright or license header.
  • Docusaurus builds
    • All pages that are touched by this PR load properly

Example describes how to handle Interface documentation for the KITs
@ClosedSourcerer
Copy link
Contributor Author

Dash runner failed because of http 429 "too many requests"
I am not allowed to trigger a re-run and would appreciate it if someone did re-run the dash job.

[main] INFO Querying ClearlyDefined for license data for 500 items.
[main] ERROR Error response from ClearlyDefined HTTP 429
Run changed=$(git diff DEPENDENCIES)

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

usage: "Eclipse-tractusx website repository"
url: "https://github.com/eclipse-tractusx/eclipse-tractusx.github.io"
openApiSpecs:
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/main/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future one could also think of creating tags in the website repo at every release to version the api specs (as far as I understood, currently only the kits documentation is "versioned" via a folder structure).

Suggested change
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/main/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml"
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/refs/tags/R25.03/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml"
- "https://raw.githubusercontent.com/eclipse-tractusx/eclipse-tractusx.github.io/refs/tags/R24.12/openApi/dt/kit_digital-twin-kit-submodel-api_openAPI.yaml"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.
I agree that versioning the API references is a sensible and the only precise approach.

Afaik, currently all KITs do get "promoted" into the new release, even if there are 0 changes.
With the tagged approach updating the tags for the APIs would become a regular maintanance task that has to be performed every release.

As for the suggested changes:
Since tagging is currently not in place, integrating them would move the example away from the current reality and I want the example to reflect the current reality and not a, for now, unrealised utopia :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the suggested changed function just to make the possible future enhancement proposal more understandable and I didn't expect them to be implemented as part of this PR.

@evegufy evegufy changed the title Add example to trg 1.08 docs: add example to trg 1.08 Dec 11, 2024
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Since we already have a planned feature for upgrading docusaurus and removing open-api plug-in and using the api-hub i just want to mention the reference to this TRG/PR eclipse-tractusx/sig-release#985

@ClosedSourcerer ClosedSourcerer merged commit 2bb21cc into eclipse-tractusx:main Dec 13, 2024
5 checks passed
@ClosedSourcerer ClosedSourcerer deleted the Add-Example-to-TRG-1.08 branch December 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants