Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update TRG 7-04 to unbind DEPENDENCIES file from the main branch #1095

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Nov 22, 2024

Description

Modify TRG 7.04 to describe how the DEPENDENCIES file could be not checked in the git repository but uploaded on a static content.

As discussed in: https://github.com/orgs/eclipse-tractusx/projects/61/views/6?pane=issue&itemId=83404189

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Nov 22, 2024
@ndr-brt ndr-brt requested a review from a team November 22, 2024 15:38
@ndr-brt ndr-brt changed the title docs: update TRG 7-04 to permit to unbind DEPENDENCIES file from the main branch docs: update TRG 7-04 to unbind DEPENDENCIES file from the main branch Nov 22, 2024
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it makes sense, thus LGTM.

I have one question:

If I understood your workflows correctly, you bundle the dependencies for the release. There also is a workflow for nightlies that doesn't. You don't provide nightlies anymore on maven central, don't you?

docs/release/trg-7/trg-7-01.md Show resolved Hide resolved
@ndr-brt
Copy link
Contributor Author

ndr-brt commented Nov 26, 2024

If I understood your workflows correctly, you bundle the dependencies for the release. There also is a workflow for nightlies that doesn't. You don't provide nightlies anymore on maven central, don't you?

@tom-rm-meyer-ISST in the EDC context nightlies are not proper releases, we consider them as intermediate releases that can be used to test out new features/bugfixes but not meant to be used in production, that's why they're marked as SNAPSHOT, as they are snapshot, so we don't tag the commit, we don't publish them on maven central (only on osshr) and we don't bundle the dependencies file.

@tom-rm-meyer-ISST
Copy link
Contributor

If I understood your workflows correctly, you bundle the dependencies for the release. There also is a workflow for nightlies that doesn't. You don't provide nightlies anymore on maven central, don't you?

@tom-rm-meyer-ISST in the EDC context nightlies are not proper releases, we consider them as intermediate releases that can be used to test out new features/bugfixes but not meant to be used in production, that's why they're marked as SNAPSHOT, as they are snapshot, so we don't tag the commit, we don't publish them on maven central (only on osshr) and we don't bundle the dependencies file.

Alright, thanks for clarifying! Just as a sidenote: I think it would make sense to also bundle the file into that, too because it's some kind of distribution, even if not meant for production. I at least online was not able to find the snapshot via the osshr webpage and likely you'll only find it in your maven cache or similar - thus, maybe a cherry on the cream topic or me being too picky :)

docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-01.md Outdated Show resolved Hide resolved
@ndr-brt ndr-brt requested a review from evegufy December 2, 2024 14:49
@ndr-brt ndr-brt merged commit 303ee06 into main Dec 3, 2024
5 checks passed
@ndr-brt ndr-brt deleted the dependencies-file branch December 3, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants