-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change scdn logos #1084
Change scdn logos #1084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the PR.
The kit gallery is not working. Also I would move the new icons to the old places and remove the old ones.
docs-kits/kits/Supply Chain Disruption Notifications KIT/page_changelog.md
Outdated
Show resolved
Hide resolved
...supply-chain-disruption-notification/supply-chain-disruption-notification-gallery.drawio.svg
Outdated
Show resolved
Hide resolved
...mg/supply-chain-disruption-notification/supply-chain-disruption-notification-logo.drawio.svg
Outdated
Show resolved
Hide resolved
Sidenote I missed: You already checked the dependencies and added license files. Thus you can tick the boxes (these are meant for self-assessment) :) |
This comment was marked as resolved.
This comment was marked as resolved.
@jSchuetz88 Seems like The draw.io editor uses foreign objects (foreignObject) in the SVG data to allow complex HTML labels on shapes. |
@tom-rm-meyer-ISST I aligned with @stephanbcbauer on the folder structure for kit logos |
@Grand-Thibault We should also update the KIT guidelines to mention the new icon folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Grand-Thibault, looks better now. I updated the css-file to fix an representation issue related to the .svg file (see screenshot). This is fixed now.
Good to go from my side now.
PS: The kitsGallyery cointains a lot of duplicate code for a relatively simple function. It should be cleaned up eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @Grand-Thibault: Rework will be handled in a seperate PR. Opened #1093 for harmonization of remaining kits.
Description
The PR changes the color scheme for scdn to make it coherent with the general color scheme and introduces a new logo for the KIT that adheres more to the general style of KIT logos
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: