Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scdn logos #1084

Merged

Conversation

Grand-Thibault
Copy link
Contributor

@Grand-Thibault Grand-Thibault commented Nov 13, 2024

Description

The PR changes the color scheme for scdn to make it coherent with the general color scheme and introduces a new logo for the KIT that adheres more to the general style of KIT logos

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the PR.

The kit gallery is not working. Also I would move the new icons to the old places and remove the old ones.

@tom-rm-meyer-ISST
Copy link
Contributor

Sidenote I missed: You already checked the dependencies and added license files. Thus you can tick the boxes (these are meant for self-assessment) :)

@jSchuetz88

This comment was marked as resolved.

@Grand-Thibault
Copy link
Contributor Author

I added some code to enable .svg files for the kitsGallery.js However, there is an issue with the .svg-files. @Grand-Thibault Could you check the .svg-file (see: https://www.drawio.com/doc/faq/svg-export-text-problems)?

image

@jSchuetz88 Seems like The draw.io editor uses foreign objects (foreignObject) in the SVG data to allow complex HTML labels on shapes.
Solution: Disable formatted text and word wrap
--> done and it works

@Grand-Thibault
Copy link
Contributor Author

@tom-rm-meyer-ISST I aligned with @stephanbcbauer on the folder structure for kit logos

@stephanbcbauer
Copy link
Member

@Grand-Thibault We should also update the KIT guidelines to mention the new icon folders.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Grand-Thibault, looks better now. I updated the css-file to fix an representation issue related to the .svg file (see screenshot). This is fixed now.

image

Good to go from my side now.


PS: The kitsGallyery cointains a lot of duplicate code for a relatively simple function. It should be cleaned up eventually.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @Grand-Thibault: Rework will be handled in a seperate PR. Opened #1093 for harmonization of remaining kits.

@tom-rm-meyer-ISST tom-rm-meyer-ISST removed the request for review from stephanbcbauer November 20, 2024 14:37
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a93b3ce into eclipse-tractusx:main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants