Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demand and Capacity Management KIT 24.12 #1063

Merged
merged 277 commits into from
Nov 25, 2024

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Oct 21, 2024

Description

This PR introduces the Next Version of the Demand and Capacity Management KIT

Addressed Issues

eclipse-tractusx/sig-release#838
eclipse-tractusx/sig-release#799
eclipse-tractusx/sig-release#780
eclipse-tractusx/sig-release#773
eclipse-tractusx/sig-release#772
eclipse-tractusx/sig-release#771
eclipse-tractusx/sig-release#770
eclipse-tractusx/sig-release#769
eclipse-tractusx/sig-release#766

Added

Changed

Bug Fixes

  • Removed Catena-X NG reference
  • Unified License Notice for DCM KIT
  • Renamed DCM KIT in the sidebar and header into Demand and Capacity Management KIT in order to be consistent with the other KITs

Pre-review checks

Docusaurus builds locally all touched pages run fine locally

Please ensure to do as many of the following checks as possible, before asking for committer review:

kenobi79 and others added 30 commits October 2, 2024 15:54
@stephanbcbauer
Copy link
Member

But I think we have some bigger issues ;) Markdown linting can be solved ⇾ easy, but there are some contributors who didn't sign the ECA? That's a problem.
And for this PR we need IP Ticket because of the huge number of changes. Can you change here somehow the working model? No committer would be able to review this PR

@MWADCM @LukasSchmetz

  1. As expert group lead the working model is your issue.
  2. Please also initiate the IP Ticket with our designated commiter.
  3. @eckardg Also contacted me regarding @lanfrans requirement for the Eclipse account and ECA. Please take care of this as well

Meanwhile i created the IP Issue

@jSchuetz88 , @ClosedSourcerer Wow this was fast -> IP Tickets was approved

image

Copy link
Contributor

@kenobi79 kenobi79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jSchuetz88
Copy link
Member

jSchuetz88 commented Nov 13, 2024

@jSchuetz88

  • When the KIT gets released with 24.12 should the changelog.md of tractus-X (https://eclipse-tractusx.github.io/CHANGELOG/) get changed as well in order to reflect the move from /DCM-KIT/ to /Demand and Capacity Management KIT/

@ClosedSourcerer Sorry for the late reply.

Initial PR at latest: 15. November
Merged at latest: 29. November
Formal publication (creation of the new Version / Release): 2. December

@ClosedSourcerer
Copy link
Contributor Author

The Eclipse Dash is erroneous. Afaik this is known to @stephanbcbauer

From a business perspective: We did nit add any code, therefore any code dependencies to the KIT.

@danielmiehle If I remember correctly you volunteered to act as committer for this PR.

  • How do we proceed now?

Copy link
Contributor

@LukasSchmetz LukasSchmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections implemented as discussed with @ClosedSourcerer . LGTM

@stephanbcbauer
Copy link
Member

The Eclipse Dash is erroneous. Afaik this is known to @stephanbcbauer

From a business perspective: We did nit add any code, therefore any code dependencies to the KIT.

@danielmiehle If I remember correctly you volunteered to act as committer for this PR.

  • How do we proceed now?

@ClosedSourcerer in this case it's not the broken checker. There is really an issue. "Your" DEPENDECIES file is not up-to-date. There are new states "on the server" which are right now not in your DEPENDENCIES file. This is not done automatically.

left your file, right the new status of the lib
image

There are two options:

  1. maybe someone already updated the DEPENDENCIES file on main, and you can just merge it
  2. you have to update the file locally on your own and push it to your branch

@stephanbcbauer
Copy link
Member

The Eclipse Dash is erroneous. Afaik this is known to @stephanbcbauer
From a business perspective: We did nit add any code, therefore any code dependencies to the KIT.
@danielmiehle If I remember correctly you volunteered to act as committer for this PR.

  • How do we proceed now?

@ClosedSourcerer in this case it's not the broken checker. There is really an issue. "Your" DEPENDECIES file is not up-to-date. There are new states "on the server" which are right now not in your DEPENDENCIES file. This is not done automatically.

left your file, right the new status of the lib image

There are two options:

  1. maybe someone already updated the DEPENDENCIES file on main, and you can just merge it
  2. you have to update the file locally on your own and push it to your branch

Additional information to update the DEPENDENCIES file ... here the command, needs to be executed in root folder

java -jar org.eclipse.dash.licenses-1.1.0.jar package-lock.json -project automotive.tractusx -summary ./DEPENDENCIES

https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-04#checking-libraries-using-the-eclipse-dash-license-tool

@ClosedSourcerer
Copy link
Contributor Author

@stephanbcbauer Thank you, I already had dependencies mentally taken care off and totally forgot that between the DB being down and dash working beforehand that I might just need to merge the upstream back into downstream to get this fixed.

@stephanbcbauer
Copy link
Member

@stephanbcbauer Thank you, I already had dependencies mentally taken care off and totally forgot that between the DB being down and dash working beforehand that I might just need to merge the upstream back into downstream to get this fixed.

i think merging helped :)

Copy link
Contributor

@danielmiehle danielmiehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maximilianong maximilianong self-requested a review November 25, 2024 08:34
@maximilianong maximilianong merged commit 4c1b7a2 into eclipse-tractusx:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.