Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport knowledge-agents 24.08 changes to versioned folder. #1034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Sep 18, 2024

Description

Companion PR to #1006 in order to sync the versioned folder of the knowledge agents kit 24.08 with its main version.

Pre-review checks

DEPs are outdated already in the main branch. Did not do any changes to the modules.

Please ensure to do as many of the following checks as possible, before asking for committer review:

@drcgjung drcgjung requested a review from obalandi September 18, 2024 06:17
@drcgjung drcgjung added the documentation Improvements or additions to documentation label Sep 18, 2024
@stephanbcbauer
Copy link
Member

I updated the DEPENDENCIES file → checkbox can be checked

@stephanbcbauer
Copy link
Member

I also created an IP Ticket because of the number of changes in this PR

@stephanbcbauer
Copy link
Member

@jSchuetz88 IP Ticket is still under review, what about the committers?

Copy link

@obalandi obalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephanbcbauer
Copy link
Member

LGTM!

Thx, still waiting for the IP review

@stephanbcbauer
Copy link
Member

LGTM!

Thx, still waiting for the IP review

@jSchuetz88 IP issues was approved!!

@stephanbcbauer
Copy link
Member

@jSchuetz88 can you please have a look? This PR is older and updates an already released KIT version. THX

@@ -32,6 +32,16 @@ sidebar_position: 1

All notable changes to the (Knowledge) Agents KIT will be documented in this file.

## [1.2.0] - 2024-07-29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [1.2.0] - 2024-07-29
## [1.2.0] - 2024-12-02

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience. Looks good to me. As the IP Ticket has been also approved, good to go.

One minor remark: Consider to update the date in the changelog to the actual publication / release date (see suggestion). This is not a blocker, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants