-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backport knowledge-agents 24.08 changes to versioned folder. #1034
base: main
Are you sure you want to change the base?
fix: backport knowledge-agents 24.08 changes to versioned folder. #1034
Conversation
I updated the DEPENDENCIES file → checkbox can be checked |
I also created an IP Ticket because of the number of changes in this PR |
@jSchuetz88 IP Ticket is still under review, what about the committers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thx, still waiting for the IP review |
@jSchuetz88 IP issues was approved!! |
@jSchuetz88 can you please have a look? This PR is older and updates an already released KIT version. THX |
@@ -32,6 +32,16 @@ sidebar_position: 1 | |||
|
|||
All notable changes to the (Knowledge) Agents KIT will be documented in this file. | |||
|
|||
## [1.2.0] - 2024-07-29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [1.2.0] - 2024-07-29 | |
## [1.2.0] - 2024-12-02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience. Looks good to me. As the IP Ticket has been also approved, good to go.
One minor remark: Consider to update the date in the changelog to the actual publication / release date (see suggestion). This is not a blocker, though.
Description
Companion PR to #1006 in order to sync the versioned folder of the knowledge agents kit 24.08 with its main version.
Pre-review checks
DEPs are outdated already in the main branch. Did not do any changes to the modules.
Please ensure to do as many of the following checks as possible, before asking for committer review: