Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traceability KIT 24.12] Block Notification #1028

Conversation

johannsvarela
Copy link
Contributor

@johannsvarela johannsvarela commented Sep 9, 2024

Description

This PR updates the sections below with content of the new block notification for the upcoming release 24.12. For detailed information regarding the changes made have a look at the updated changelog file.

  • Business View
  • Architecture View
  • Development View

Related Issues

Fixes eclipse-tractusx/sig-release#782 / https://github.com/catenax-eV/sig-roadmap/issues/17

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer
Copy link
Member

stephanbcbauer commented Nov 20, 2024

@johannsvarela , @eckardg , @jSchuetz88 can you please check together if this PR is still valid? THX do you need any support?

@ndr-brt
Copy link
Contributor

ndr-brt commented Nov 21, 2024

@johannsvarela May I ask why the review has been asked to all the committers?
The automotive-tractusx-committers group should be used only for topics of interest to all the committers (TRGs, decisions...), but not for use case specific ones.
Reason: my "review-requested" tab is bloated with this kind of PR and the really important stuff is drown somewhere there :)

@johannsvarela johannsvarela removed the request for review from a team November 21, 2024 08:09
@johannsvarela
Copy link
Contributor Author

@johannsvarela May I ask why the review has been asked to all the committers? The automotive-tractusx-committers group should be used only for topics of interest to all the committers (TRGs, decisions...), but not for use case specific ones. Reason: my "review-requested" tab is bloated with this kind of PR and the really important stuff is drown somewhere there :)

Thanks for the hint! I removed the automotive-tractusx-committers group as committers.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johannsvarela,

thank you for the update of the KIT. Looks good, I just have some formal findings, mostly related to missing licence-files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the corresponding licence-file.

@johannsvarela
Copy link
Contributor Author

@jSchuetz88 All change requests were done! Please have a look at the added and adapted files!

@eckardg eckardg removed their assignment Dec 2, 2024
@jSchuetz88
Copy link
Member

jSchuetz88 commented Dec 2, 2024

@jSchuetz88 All change requests were done! Please have a look at the added and adapted files!

@johannsvarela Thank you. I think you missed one: "quality_notifications.png.license" if you can rename it to "quality_notifications.svg.license" we are good to go.

... and for some reason, the 3rd Party dependency check complains again.

@stephanbcbauer
Copy link
Member

Overall PR is release relevant ⇾ licence needs to be renamed ⇾ Will be done via bug fix
content checked by @jSchuetz88 , @ther3sa , @stephanbcbauer

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see last comment

@stephanbcbauer stephanbcbauer merged commit a782925 into eclipse-tractusx:main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R24.12] Traceability KIT Adaptation: Notifications Extension: Block-notification
6 participants