-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traceability KIT 24.12] Block Notification #1028
[Traceability KIT 24.12] Block Notification #1028
Conversation
…ication-release-24.12
@johannsvarela , @eckardg , @jSchuetz88 can you please check together if this PR is still valid? THX do you need any support? |
…ication-release-24.12
@johannsvarela May I ask why the review has been asked to all the committers? |
Thanks for the hint! I removed the automotive-tractusx-committers group as committers. |
…ication-release-24.12
…ication-release-24.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johannsvarela,
thank you for the update of the KIT. Looks good, I just have some formal findings, mostly related to missing licence-files.
docs-kits/kits/Traceability Kit/assets/architecture_level_1.svg
Outdated
Show resolved
Hide resolved
docs-kits/kits/Traceability Kit/assets/block-notification-state-model-interaction.svg
Outdated
Show resolved
Hide resolved
docs-kits/kits/Traceability Kit/assets/block-notification-state-model.svg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the corresponding licence-file.
docs-kits/kits/Traceability Kit/assets/quality_notifications.svg
Outdated
Show resolved
Hide resolved
docs-kits/kits/Traceability Kit/diagrams/block-notification-update-status.svg
Outdated
Show resolved
Hide resolved
docs-kits/kits/Traceability Kit/diagrams/block-notification-send-receive.svg
Outdated
Show resolved
Hide resolved
...s/Traceability Kit/Software Development View/page_app-provider_software-development-view.mdx
Outdated
Show resolved
Hide resolved
…ication-release-24.12
@jSchuetz88 All change requests were done! Please have a look at the added and adapted files! |
@johannsvarela Thank you. I think you missed one: "quality_notifications.png.license" if you can rename it to "quality_notifications.svg.license" we are good to go. ... and for some reason, the 3rd Party dependency check complains again. |
Overall PR is release relevant ⇾ licence needs to be renamed ⇾ Will be done via bug fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see last comment
Description
This PR updates the sections below with content of the new block notification for the upcoming release 24.12. For detailed information regarding the changes made have a look at the updated changelog file.
Related Issues
Fixes eclipse-tractusx/sig-release#782 / https://github.com/catenax-eV/sig-roadmap/issues/17
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: