-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Business Partner KIT]: removed open api plugin usage #1020
[Business Partner KIT]: removed open api plugin usage #1020
Conversation
Hi @jSchuetz88 @danielmiehle , could you please check pull request as waiting from long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SujitMBRDI,
thank you for removing the API. I actually like the idea, to update the references to the SwaggerHub UI instead of removing them completely. Unfortunately, the links to SwaggerHub don't work right now, but that should be automatically fixed, after the merge and automated scan of the openAPIs.
Only one change request (@danielmiehle please correct me here if I'm wrong): But the references also need to be removed from previous versions and not only for the "next" release. Otherwise we won't be able to get rid of the plugin.
Hi @jSchuetz88, Thank you for reviewing the changes. Good to hear that you like the idea where we are linking api-hub swagger documentation for development view. Also you are right, the links will work after merge and once automated scan for OpenApi finish. I have provided link based on expected result of auto scan(it is high guess from our side). |
IP Ticket created |
@jSchuetz88 IP Ticket is still under review |
Hi @jSchuetz88, @stephanbcbauer I can see the IP ticket is approved as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
With this pull request, removed open api plugin usage for business patner kit and also removed unnecessary
.mdx
files. We have added hyperlink of swagger documentation for each service from bpdm in business partner kit's development view which make kit more readable.Fix #971
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: