Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Quality gate changes #6

Merged
merged 9 commits into from
Feb 27, 2023
Merged

Conversation

adkumar1
Copy link
Contributor

No description provided.

@adkumar1
Copy link
Contributor Author

Fixed it

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please resolve comment regarding notice.md file

NOTICE.md Outdated Show resolved Hide resolved
@carslen
Copy link
Contributor

carslen commented Feb 27, 2023

And please remove .DS_STORE file, as @Siegfriedk mentioned @adkumar1

@carslen
Copy link
Contributor

carslen commented Feb 27, 2023

Please change your commit message strategy: Update file is not an expected commit message due to our guidelines: "Check for meaningful and descriptive commit messages (amend / sqash committs for a PR)"

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carslen carslen merged commit f169dea into eclipse-tractusx:main Feb 27, 2023
@carslen carslen deleted the release1.7.3 branch February 27, 2023 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants