Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update some build tool versions and fixing the vault version to a compatible one #135

Merged
merged 5 commits into from
Jan 13, 2025
Merged

chore: Update some build tool versions and fixing the vault version to a compatible one #135

merged 5 commits into from
Jan 13, 2025

Conversation

lgblaumeiser
Copy link
Contributor

@lgblaumeiser lgblaumeiser commented Jan 13, 2025 •
edited
Loading

WHAT

  • Fixed the vault chart to version 0.28.0 in deployment and upgradability tests
  • Updated the used actions to newer versions
  • Updated used Kubernetes and Helm versions
  • Updated the standard helm chart to use Postgres 15 and vault 1.16.1 as used in the tests, resp. by EDC

WHY

  • The free floating vault installation let to a version that is buggy (v1.18.1). It cannot handle urls with encoded slashs properly. Had to downgrade to v1.16.1 which is installed by chart version 0.28.0
  • Updated to keep the versions used up to date, as the helm lint showed, that with some not fixed dependencies, like the ubuntu version on which the tests run, might lead to issues as some old tooling is not supported anymore.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2025
View reviewed changes
.github/workflows/upgradeability-test.yaml

- name: Create k8s Kind Cluster
uses: helm/kind-action@v1.10.0
uses: helm/kind-action@v1.12.0

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
@lgblaumeiser lgblaumeiser changed the title chore: Update used kubernetes and related tools version in builds chore: Update some build tool versions and fixing the vault version to a compatible one Jan 13, 2025
@lgblaumeiser lgblaumeiser force-pushed the chore/update_build_versions branch from 55abad6 to 063cd65 Compare January 13, 2025 14:23
@lgblaumeiser
dependencies
2e1f76d 
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
@lgblaumeiser lgblaumeiser mentioned this pull request Jan 13, 2025
Closed
@lgblaumeiser lgblaumeiser force-pushed the chore/update_build_versions branch 3 times, most recently from 36dac0d to e68a1c1 Compare January 13, 2025 14:58
@lgblaumeiser
update chart
7bca712 
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
@lgblaumeiser lgblaumeiser force-pushed the chore/update_build_versions branch from e68a1c1 to 7bca712 Compare January 13, 2025 15:00
@lgblaumeiser lgblaumeiser requested a review from ndr-brt January 13, 2025 15:01
@lgblaumeiser
dependencies
4464f22 
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
@lgblaumeiser lgblaumeiser force-pushed the chore/update_build_versions branch from e00510c to 4464f22 Compare January 13, 2025 15:07
ndr-brt
ndr-brt approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgblaumeiser lgblaumeiser merged commit 1731e52 into main Jan 13, 2025
25 checks passed
@lgblaumeiser lgblaumeiser deleted the chore/update_build_versions branch January 13, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgblaumeiser @ndr-brt