Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpdm-gate): updated upload partner process to only process site and address partners #980

Conversation

SujitMBRDI
Copy link
Contributor

Description

In this pull request, we have modified the partner upload process in the bpdm-gate service to only create or update site and address business partner.
Additionally, the legal entity BPN value will now be derived from the tenant's BPNL value.

why

700

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI requested a review from nicoprow June 27, 2024 07:10
@SujitMBRDI SujitMBRDI self-assigned this Jun 27, 2024
@SujitMBRDI SujitMBRDI assigned nicoprow and unassigned SujitMBRDI Jul 5, 2024
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one doubt:

I think this algorithm needs to make sure that there definitely exists a BPNL to which the user can add records. This means to me that if no tenantBpnl exists it should return an error instead of trying to create records of an unknown legal entity.

What do you think?

@SujitMBRDI

@nicoprow nicoprow assigned SujitMBRDI and unassigned nicoprow Jul 8, 2024
@SujitMBRDI
Copy link
Contributor Author

Looks good except one doubt:

I think this algorithm needs to make sure that there definitely exists a BPNL to which the user can add records. This means to me that if no tenantBpnl exists it should return an error instead of trying to create records of an unknown legal entity.

What do you think?

@SujitMBRDI

@nicoprow Yes, I agree to your suggestion here.
Even i think the existence of tenantBpnl must be first validation check for this algorithm before go into other field mapping process. If tenantBpnl is missing then ideally we should not perform upload partner upload process.

@SujitMBRDI SujitMBRDI force-pushed the feat/update_partner_upload_endpoint branch from 8420c99 to 3728895 Compare July 8, 2024 10:32
@SujitMBRDI SujitMBRDI requested a review from nicoprow July 8, 2024 10:33
…and address partners

feat(bpdm-gate): updated upload partner process to only process site and address partners
@SujitMBRDI SujitMBRDI force-pushed the feat/update_partner_upload_endpoint branch from 3728895 to da24adf Compare July 8, 2024 10:43
@SujitMBRDI SujitMBRDI merged commit 201db14 into eclipse-tractusx:main Jul 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants