Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bpdm-gate): refactored swagger docs for partner upload api #979

Merged

Conversation

SujitMBRDI
Copy link
Contributor

@SujitMBRDI SujitMBRDI commented Jun 25, 2024

Description

Updated swagger documentation for business partner upload api and also removed unwanted dependencies.

Why

700

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI requested a review from nicoprow June 25, 2024 11:52
@SujitMBRDI SujitMBRDI self-assigned this Jun 25, 2024
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us keep the commit description "fix" for when we introduce bug fixes to application or deployment logic. Could you change the commit message prefix to "docs" instead?

Also we should reference the issue this pull request contributes to, as we have an existing issue.

@SujitMBRDI
Copy link
Contributor Author

SujitMBRDI commented Jun 26, 2024

Let us keep the commit description "fix" for when we introduce bug fixes to application or deployment logic. Could you change the commit message prefix to "docs" instead?

Also we should reference the issue this pull request contributes to, as we have an existing issue.

Sure thing, Done.

@SujitMBRDI SujitMBRDI changed the title fix(bpdm-gate): refactored swagger docs for partner upload api docs(bpdm-gate): refactored swagger docs for partner upload api Jun 26, 2024
@SujitMBRDI SujitMBRDI requested a review from nicoprow June 26, 2024 03:46
@SujitMBRDI SujitMBRDI merged commit dcd4cc6 into eclipse-tractusx:main Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants