Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Auth): add tests for accessing authenticated BPDM API access #867

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Apr 16, 2024

Description

This pull request adds authentication tests to the BPDM test setup.

  • add Keycloak test container
  • add test configuration for authenticated clients for accessing the own API
  • add authentication tests for different roles

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- add Keycloak test container
- add test configuration for authenticated clients for accessing the own API
- add authentication tests for different roles
Copy link

gitguardian bot commented Apr 16, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10374411 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374412 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374413 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374414 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374415 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374416 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374417 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
10374418 Triggered Generic High Entropy Secret 3b40e63 bpdm-common-test/src/main/resources/keycloak/CX-Central.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nicoprow nicoprow marked this pull request as ready for review April 16, 2024 07:43
@nicoprow nicoprow merged commit 4765f8f into main Apr 16, 2024
8 checks passed
@nicoprow nicoprow deleted the feat/keycloak branch April 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant