fix(charts): fix default dependency service #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed postgres service name and password - fixed service names for dependencies between BPDM charts
4 tasks
|
Contributes towards #795 |
FaGru3n
suggested changes
Mar 1, 2024
There was a problem hiding this comment.
Hi @nicoprow thanks for your fast work.
saw that you removed the fullnameOverwrite setting and i guess with "nameOverwrite" setting should also be fine and guess would help evelyn with theirs issue, and pointed it out in some suggested changes to your PR.
and as stated in TRG 5.01
Dependencies should be prefixed with the nameOverride and/or fullnameOverride properties
rest LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes how the BPDM Charts resolve default service names of dependencies. The umbrella and subcharts now find the postgres dependency and the password on default without any configuration needed.
Also fixed how the Charts resolve the default service names for other BPDM charts that they are dependend on.
Fixes #786
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: