Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Gate): empty owner BPNL leading to forbidden errors #741

Merged

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Feb 7, 2024

Description

When setting null to owner BPNL in Gate, no endpoint can't be accessed anymore as Forbidden is returned.

This pull request fixes empty owner BPNL leading to forbidden errors in Gate

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- Made the owner BPNL now not nullable because of binding behaviour of Spring
- Rather check whether BPNL is blank than null since property normally will not be bound as null anyway
@nicoprow nicoprow added the bug Something isn't working label Feb 7, 2024
@nicoprow nicoprow marked this pull request as ready for review February 7, 2024 03:30
@nicoprow nicoprow merged commit 52a27e1 into eclipse-tractusx:main Feb 7, 2024
9 checks passed
@nicoprow nicoprow deleted the fix/gate/owner-property-nullable branch February 7, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant