Feat/BPDM2-545-GateClientModule #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Mar 13, 2023
There was a problem hiding this comment.
The package structure is not very appropriate for a library. I would propose the following renaming of packages:
dto -> model (as in this is the model for the gate api)
config -> client
service -> (interfaces there to root folder so they are in the package bpdm.gate.api)
Since we don't need the webtestclient so often in the tests anymore, there are now some Endpoint variables not being used in the bpdm-gate test folder under util.Endpoints. Please delete the redundant ones.
Other than refactoring issues everything else looks good
...ient/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/client/config/GateClientServiceConfig.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/org/eclipse/tractusx/bpdm/gate/client/service/GateClientAddressInterface.kt
Outdated
Show resolved
Hide resolved
alexsilva-CGI
force-pushed
the
feat/BPDM2-545-GateClientModule
branch
from
95422a7 to
ee5adf4
Compare
nicoprow
requested changes
Mar 14, 2023
nicoprow
approved these changes
Mar 15, 2023
nicoprow
requested changes
Mar 16, 2023
...src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/client/ParameterObjectArgumentResolver.kt
Outdated
Show resolved
Hide resolved
alexsilva-CGI
force-pushed
the
feat/BPDM2-545-GateClientModule
branch
from
3b969e4 to
9a4c753
Compare
…, Interface implementation on Gate Controllers
…ncies and variables removal
…umentResolver class moved to common module
… module path on deploy-maven and build-docker-all yaml's
alexsilva-CGI
force-pushed
the
feat/BPDM2-545-GateClientModule
branch
from
9a4c753 to
8aefd44
Compare
nicoprow
reviewed
Mar 16, 2023
bpdm-gate-api/pom.xml
Outdated
| <repository> | ||
| <id>github</id> | ||
| <name>GitHub CatenaX-NG Apache Maven Packages</name> | ||
| <url>https://maven.pkg.github.com/catenax-ng/bpdm-gate-api</url> |
There was a problem hiding this comment.
need to replace bpdm-gate-api with the repository name tx-bpdm
nicoprow
requested changes
Mar 16, 2023
nicoprow
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Feature: Gate Client Module that is invoked in the BPDM Gate Tests