Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Site Name and Address Name to Generic Business Partner Model #689

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Dec 20, 2023

Description

This pull request adds site name and address name to the generic business partner model. By this changing the gate and the orchestrator api. I also added a migration script for the Gate to persist the new names.

Since we now have specific names the cleaning service now uses site and address name of the generic business partner to fill the respective names in the L/S/A model. Legal name will be still taken from the name parts though because we don't expect sharing members to provide the legal name themselves.

Test values and tests have been adapted where appropriate.

Contributes to #672

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow force-pushed the feat/generic-add-names branch from bc95f4e to 4735d25 Compare December 29, 2023 03:14
@nicoprow nicoprow marked this pull request as ready for review December 29, 2023 03:22
@nicoprow nicoprow merged commit 0d670d5 into eclipse-tractusx:main Dec 29, 2023
9 checks passed
@nicoprow nicoprow deleted the feat/generic-add-names branch December 29, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant