Fix/gate/sharing status response #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
force-pushed
the
fix/gate/sharing-status-response
branch
2 times, most recently
from
6e0480d to
200ecaf
Compare
…as updates exists
nicoprow
force-pushed
the
fix/gate/sharing-status-response
branch
from
200ecaf to
0998aa7
Compare
martinfkaeser
suggested changes
Mar 14, 2023
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/OutputSaasMappingService.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/LegalEntityService.kt
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/OutputSaasMappingService.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/model/BusinessPartnerSaaSWithBpn.kt
Outdated
Show resolved
Hide resolved
…for BPN resolution - sites now consider augmented business partner entries for sites - addresses now consider augmented business partner entries for addresses
…ound in pool - for legal entities when legal address is missing in pool - for sites when main address is missing in pool
|
I think I can't officially approve the PR, but it looks good now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BPDM Gate: The Output endpoints could miss returning any information for Business Partners without SaaS update information