Refactoring: Reorganize Legal Entity DTOs between modules #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DTOs related to legal entities were refactored, making sure all its data classes are located in the appropriate API modules (gate-api, pool-api and orchestrator-api). Common interfaces are used whenever possible.
This meant splitting up and adjusting some DTOs for the different modules which were formerly in the common module.
Some properties which for a specific module are always used besides
LegalEntityDtowere directly added: in the PoollegalName; in the GatelegalNamePartsandroles.I decided that the verbose DTOs should not be part of the normal interface hierarchy because this would add a lot more complexity and the verbose DTOs are only used in the Pool.
This is another step towards #570