Charts(BPDM): Updated helm test running workflow #656
Conversation
SujitMBRDI
force-pushed
the
feat/update_helm_chart_lint
branch
from
ae0ff5c to
2693acf
Compare
|
Hi @SujitMBRDI could you please modify your changes against @nicoprow s and my comment on #645 |
Hello @FaGru3n, i have adapted changes please help to review. |
There was a problem hiding this comment.
Hi @SujitMBRDI, thanks for adapting the workflow example, but as @nicoprow mentioned it , i would assume that there is a dedicated strategy behind it.
So validation for QG-Check would be enough for me adding the step Run helm upgrade and make it manually executable with workflow_dispatch trigger in the workflow
|
@nicoprow do you maybe have a bit of time where we can talk together with @SujitMBRDI about the workflow strategy? |
|
@FaGru3n we can align on this, you can invite me to a call. I aligned with Sujit on this workflow already. For me it is just important to not test the charts on the built docker images in the workflow but take the referenced charts from Dockerhub as default. The other changes torwards versions and removing testing of child charts I aligned with Sujit. I don't think it is necessary for now to also test the child charts separately if we already test the umbrella chart, as this workflow is running long enough already... |
|
little meeting on 10:30 CET / GMT +1 |
|
@nicoprow maybe you want to merge, i guess to that the workflow ideas suits your handling and strategy 😉 |
|
|
||
| # install the chart to the kind cluster and run helm test | ||
| # define charts to test with the --charts parameter | ||
| run: ct lint --validate-maintainers=false --target-branch ${{ github.event.repository.default_branch }} |
There was a problem hiding this comment.
here please also include parameter --config charts/config/chart-testing-config.yaml
(then you don't need --validate-maintainers=false because its already included in the config)
SujitMBRDI
force-pushed
the
feat/update_helm_chart_lint
branch
from
b64587d to
98ad07c
Compare
Description
Updated helm test running workflow outdated.
Fixes #645
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: