Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pool): #556 Upsert Business Partners from Cleaning Result - refactor validation #619

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat(pool): #556 Upsert Business Partners from Cleaning Result - refactor validation #619

merged 1 commit into from
Nov 23, 2023

Conversation

rainer-exxcellent
Copy link
Contributor

@rainer-exxcellent rainer-exxcellent commented Nov 14, 2023 •
edited
Loading

Description

Upsert Business Partners from Cleaning Result - refactor validation
prepare validation so that it can be called also by orchstrator

Solves: #556

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@rainer-exxcellent rainer-exxcellent marked this pull request as ready for review November 15, 2023 07:39
nicoprow
nicoprow approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the validators in the request validation service. Looks good to me

martinfkaeser
martinfkaeser suggested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@martinfkaeser martinfkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Validators approach!
I added some suggestions for simplifing the code.
As you are already working on a follow-up PR, you best add your changes in the next PR.

bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Outdated Show resolved Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Show resolved Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Outdated Show resolved Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Outdated Show resolved Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Outdated Show resolved Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt Show resolved Hide resolved
@rainer-exxcellent rainer-exxcellent force-pushed the refactor/orchestrator_pool_validations branch from 70af9be to fc44a12 Compare November 21, 2023 06:08
@rainer-exxcellent rainer-exxcellent force-pushed the refactor/orchestrator_pool_validations branch from fc44a12 to 2b83f8d Compare November 21, 2023 07:25
@nicoprow nicoprow merged commit 1f2f63d into eclipse-tractusx:main Nov 23, 2023
8 checks passed
@nicoprow nicoprow deleted the refactor/orchestrator_pool_validations branch November 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoprow nicoprow nicoprow approved these changes

@martinfkaeser martinfkaeser martinfkaeser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rainer-exxcellent @martinfkaeser @nicoprow