Feat (Gate) - Added new error for missing task in orchestrator #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Nov 16, 2023
| errorRequests.addAll(sharingStatesWithoutTasks.map { sharingState -> | ||
| SharingStateService.ErrorRequest( | ||
| SharingStateService.SharingStateIdentifierDto(sharingState.externalId, sharingState.businessPartnerType), | ||
| BusinessPartnerSharingError.SharingProcessError, |
There was a problem hiding this comment.
I think this would be a good opportunity to introduce another Sharing Error Type that is specific to having a missing Task-ID
There was a problem hiding this comment.
I added a new type named MissingTaskID for now.
fabiodmota
approved these changes
Nov 16, 2023
nicoprow
approved these changes
Nov 20, 2023
nicoprow
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new error message to a sharing state, when a request is done to the orchestrator with the task-id, but no related task is found.
Related issues: #589
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: