Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(BPDM): Clean import and unused vars for code smelling #602

Merged

Conversation

fabiodmota
Copy link
Contributor

@fabiodmota fabiodmota commented Nov 3, 2023

Description

General code improvement in all Modules.
Removal of imports.
Removal of unused code and variables.
Logic improvement in separate ifs with equal conditions.
Removal of unnecessary assert not null.

Issues: #578 #579 #576

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The commit though has the wrong type. instead of starting with 'feat' should be 'refactor'

@fabiodmota
Copy link
Contributor Author

Looks good!

The commit though has the wrong type. instead of starting with 'feat' should be 'refactor'

Thanks for the correction , I runned up with sonar and Trivy locally before cleaning

Copy link
Contributor

@martinfkaeser martinfkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at CreateSQLScriptToInsertRegions, the rest looks great!

@fabiodmota fabiodmota force-pushed the fix/Clean_imports_and_unused_vars branch from 46fd81e to b5b5736 Compare November 16, 2023 15:36
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one test of the Pool failing due to a rounding error it seems. Please have a look and correct the

@fabiodmota fabiodmota force-pushed the fix/Clean_imports_and_unused_vars branch from b5b5736 to f3b1a51 Compare November 20, 2023 09:14
@fabiodmota
Copy link
Contributor Author

There is one test of the Pool failing due to a rounding error it seems. Please have a look and correct the

All passed and rebased on current main

@nicoprow nicoprow merged commit c84d462 into eclipse-tractusx:main Nov 21, 2023
7 checks passed
@nicoprow nicoprow deleted the fix/Clean_imports_and_unused_vars branch November 21, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants