-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(BPDM): Clean import and unused vars for code smelling #602
Refactor(BPDM): Clean import and unused vars for code smelling #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The commit though has the wrong type. instead of starting with 'feat' should be 'refactor'
Thanks for the correction , I runned up with sonar and Trivy locally before cleaning |
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/util/CreateSQLScriptToInsertRegions.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at CreateSQLScriptToInsertRegions, the rest looks great!
46fd81e
to
b5b5736
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one test of the Pool failing due to a rounding error it seems. Please have a look and correct the
b5b5736
to
f3b1a51
Compare
All passed and rebased on current main |
Description
General code improvement in all Modules.
Removal of imports.
Removal of unused code and variables.
Logic improvement in separate ifs with equal conditions.
Removal of unnecessary assert not null.
Issues: #578 #579 #576
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: