Refactor(Pool): remove opensearch component from Pool #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiodmota
reviewed
Nov 3, 2023
There was a problem hiding this comment.
is SAAS_import still used also?
There was a problem hiding this comment.
SAAS is not used anymore but I felt like I didn't want to touch that topic in this pull request :)
fabiodmota
approved these changes
Nov 3, 2023
SujitMBRDI
reviewed
Nov 7, 2023
nicoprow
force-pushed
the
refactor/pool/remove-opensearch
branch
from
a3d7cef to
70434b2
Compare
- Opensearch is no longer needed as search functionality is part of the database now - removed opensearch code from Pool and Pool API - removed mentionings of opensearch from documentation - removed opensearch from tests - kept opensearch still on Charts as charts need to be adapted in a two-step process
nicoprow
force-pushed
the
refactor/pool/remove-opensearch
branch
from
70434b2 to
b9b7a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #577
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: