Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Generic): naming of BPN fields in generic business partner #596

Merged

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Nov 2, 2023

Description

This pull request aligns with the specification of the Generic Business Partner model for BPN fields: #382. I renamed the generic business partner's BPN fields in order to better represent their meaning, as explained in the linked issue.

I changed the code of the API but left entities unchanged.

Fixes #594

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow marked this pull request as ready for review November 2, 2023 13:42
@nicoprow nicoprow changed the title feat(Generic): rename BPN fields in generic business partner fix(Generic): naming of BPN fields in generic business partner Nov 3, 2023
@nicoprow nicoprow requested a review from SujitMBRDI November 3, 2023 09:43
@nicoprow nicoprow force-pushed the feat/generic-bpn-field-names branch from 9427403 to f296fe7 Compare November 3, 2023 13:04
@nicoprow nicoprow merged commit 75aaf79 into eclipse-tractusx:main Nov 3, 2023
1 check passed
@nicoprow nicoprow deleted the feat/generic-bpn-field-names branch November 3, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Rename BPN Fields
3 participants