feat(pool): #556 Upsert Business Partners from Cleaning Result - refactoring #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
approved these changes
Oct 26, 2023
rainer-exxcellent
force-pushed
the
refactor/orchestrator_pool_dtos
branch
2 times, most recently
from
af5bbb3 to
6c709db
Compare
nicoprow
requested changes
Nov 7, 2023
…ng Result - refactor validation and persistence
rainer-exxcellent
force-pushed
the
refactor/orchestrator_pool_dtos
branch
from
6c709db to
9066e5b
Compare
I rebased the branch to the current main |
nicoprow
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor code to reuse the logic to convert dtos to entities. Add some abstrct methods to Interfaces to suport this.
Pre-review checks
Solves issue #556 partly