Feat (Gate) - Resolve Finished Cleaning Task #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
force-pushed
the
feat/resolve_finished_cleaning_task
branch
from
58039ed to
b2dd91b
Compare
nicoprow
requested changes
Oct 19, 2023
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/BusinessPartnerService.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/BusinessPartnerService.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/util/BusinessPartnerGenericValues.kt
Outdated
Show resolved
Hide resolved
nicoprow
requested changes
Oct 19, 2023
alexsilva-CGI
force-pushed
the
feat/resolve_finished_cleaning_task
branch
from
21d1b6c to
7a14e72
Compare
alexsilva-CGI
force-pushed
the
feat/resolve_finished_cleaning_task
branch
from
7a14e72 to
c6edfe5
Compare
nicoprow
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the BPDM Gate can poll the BPDM Orchestrator whether there is already a final cleaning result for the respective cleaning task. When a new cleaning result for a finished cleaning task has been returned by the Orchestrator the Gate then saves the cleaning result as a generic business partner output, resolves the task identifier and updates the sharing state of the respective business partner. Also, some Unit tests have been added.
Related to #430
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: